-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add row and col scaling functions to distributed matrix #1640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. That is a lot simpler than I expected.
9b99cc5
to
7624a74
Compare
7624a74
to
e8b7c5b
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1640 +/- ##
===========================================
+ Coverage 90.01% 90.26% +0.24%
===========================================
Files 759 759
Lines 61173 61204 +31
===========================================
+ Hits 55067 55243 +176
+ Misses 6106 5961 -145 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to assume that the scaling factors have unit stride - that's not necessarily true
Co-authored-by: Tobias Ribizel <mail@ribizel.de>
43a9260
to
3c16ba4
Compare
This PR adds a
row_scale
and acol_scale
function to the distributed matrix. This functionality is needed in openCARP.communicate
.