Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing OpenMP kernels #226

Closed
tcojean opened this issue Feb 13, 2019 · 1 comment
Closed

Implement missing OpenMP kernels #226

tcojean opened this issue Feb 13, 2019 · 1 comment
Assignees
Labels
is:enhancement An improvement of an existing feature. mod:openmp This is related to the OpenMP module.

Comments

@tcojean
Copy link
Member

tcojean commented Feb 13, 2019

The purpose of this issue is to have a full OpenMP implementation of the kernels before the Ginkgo release 1.0.0.

Here is @hartwiganzt's original comment on this issue:

On the OMP issue: there are in total about 25 NOT_IMPLEMENTED in the omp branch.
I would say: let's copy complete those - in the worst case with the reference
implementation and some note saying that this still needs to be parallelized.

One way to do this is to copy the reference kernels and add some simple parallelization when possible. When doing so, it is very important to add a note in the README that the OpenMP implementation is present but needs major improvement, or is not fully parallelized (depending on the case).

On a related issue, two OpenMP tests seem particularly long. The COO test is definitely very long (in valgrind it reaches the timeout of 1500 seconds, whereas the others take around 200 seconds!). The CGS solver test also seem to possess some issues, but not to the severity of the COO one.

@tcojean tcojean added is:enhancement An improvement of an existing feature. mod:openmp This is related to the OpenMP module. labels Feb 13, 2019
@tcojean tcojean added this to the Ginkgo 1.0.0 release milestone Feb 13, 2019
@tcojean tcojean removed this from the Ginkgo 1.0.0 release milestone Apr 3, 2019
@tcojean
Copy link
Member Author

tcojean commented Apr 3, 2019

Closing this as this is now either done, or tracked by #286

@tcojean tcojean closed this as completed Apr 3, 2019
@tcojean tcojean assigned hartwiganzt and unassigned hartwiganzt Apr 3, 2019
@tcojean tcojean added this to the Ginkgo 1.0.0 release milestone Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:enhancement An improvement of an existing feature. mod:openmp This is related to the OpenMP module.
Projects
None yet
Development

No branches or pull requests

2 participants