-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unity 2018.3.7f1][Github for Unity 1.2.1-6394] Editor Freeze #1027
Comments
i use the system git with i just tried with 1.3 and did not get it to freeze (at least not in a fast test) if i press refresh/fetch in the github panel, an "git-lfs" process is started. |
@StanleyGoldman |
can you try the following steps (best in this order)
|
Btw. 1.3 froze unity for me too. if i find some time i'll do sme further investigation |
@soraphis |
@soraphis If I then change the repository origin to HTTPS instead of SSH, Github for Unity will ask me for credentials and Unity wont freeze again. |
Thats weird, because I know for a fact that one of my friends cloned it via https (having the same issue), but if I find some time i will try fiddling around with that |
My Editor is still freezing, on 2019.1.4.f1. also geting the multiple instance issue @vvalente87 had... So I restarted unity and this time I looked at the boot log for git log for unity... here are the interseting snippets:
I will poke around git-lfs stuff for a bit to try to fix this but I really don't have the time to start working on this project today. Hopefully this was helpful for someone! |
I have the same issue here |
By the way for people who have a bunch of "Git for windows" process ,you can close it from the task manager and then unity editor will work again without closing it , for each time you press the play button ,two of "Git for windows" added to the unity process |
Interesting fact. Me and a coworker both have the exact same laptop with the same applications, both work on the same project. For me it works fine but for him it freezes every time he presses play. Not sure what can cause this. |
Same issue - freezes on play press, and I've now got an incredible number of GiT tasks running in the task manager... |
Same issue for me. I uninstalled Github for Unity and everything started working again. |
Does anyone know how solve this without uninstalling github for unity? Cause I kind of need that for my project... |
Same issue on play Hold on (busy forever)... EditorApplication.playModeStateChanged; also noticed the CHanges in the github tab are no longer commiting. ANyone have a fix outside of removing github from unity? |
it seems like I have the same issue, because my whole pc was suffering recently every time i opend unity and startet working. I was realy wondering because this never happend before, but this was my first project using this plugin, so it makes quite sense. |
@Skizmo42 you could use git manualy or github desktop |
@H4x0r-000 Yep, I stopped using the extension and started using github desktop soon after and it's been working great for me ever since. |
github-unity.log (click me)
Description
Unity Freezes after making changes to the project and pressing play.
Steps to Reproduce
So i wrote a rather long e-mail to the unity support today after i opened an issue yesterday, because of the freeze. and after further investigation and testing it seems to be an issue of this plugin and not on the unity side.
the full mail is here, including every steps i made to get it to freeze - multiple times
[The mail I wrote]
Hi,
Thanks for the fast reply! After reporting the bug yesterday, i created a new project - because it seems the bug happened only in this one project.
So in this new project (Unity 2018.3.7f1) I added the meshes and materials for our project and added the Github for Unity (https://unity.github.com/) plugin.
I tested spamming the play/stop button and it never froze.
(While writing this email, i'm (re)doing those tests, so the following is kind of an log file)
(After finishing this mail I think i could pin it down to the Github for Unity plugin, and I'm going to create an issue there, but my testings and findings might be interesting for you so I'm sending the whole mail anyway. Wall of Text following)
The next thing i did was importing cinemachine (2.2.8). I added an Free Look Camera (Menu: Cinemachine > Free Look) and created an empty gameobject "lookAt" which i used as lookAt for the cinemachine Free Look Camera. (I'm not using a follow object). Pressed Play: the editor froze.
I killed the process and restarted the project. now i could play the scene without issue. I added the "lookAt" gameobject also as follow target for the cinemachine Free Look Camera. pressed play -> the editor froze.
I killed the process again, and restarted the project. pressing play and the scene does play now with a lookAt and follow target.
So i removed look at and follow target from the Free Look Camera, and pressing play worked just fine. re-adding both and pressing play made the editor freeze again.
I removed all the Cinemachine objects from the scene, moved the camera to another position. pressed play it worked. stopped and pressing play again froze the editor. after a restart it froze again.
I removed Cinemachine via the package manager. And delted the Gizmos folder cinemachine created. pressing play -> the editor froze.
After restarting it, now with cinemachine uninstalled i can spam play/stop without freezing moving the camera in the scene view and no freezing.
that made me wondering. i added a box collider to the camera, pressed play -> the editor froze.
So in the current state unity freezes when i simply add a component and press play.
I went to
\AppData\Roaming\Unity
and removed the Caches, Editor-5.x and Packages folder. Aswell as the Library, Logs and Temp folder in my Project.I restarted the project, opened my scene again.
spamming play/stop does not result in a freeze.
removing the box collider from the camera (that was saved earlier) and pressing play does not result in a freeze.
adding it again and pressing play - does not result in a freeze
changing the editor layout to my preferences.
changing positions, adding components - pressing play: no freeze.
my conclusions out of this testing (so far)
maximizing the editor window - pressing play: freeze (at this point i was like WTF)
restarted the editor, changed the layout again because it was not saved.
pressing play - worked. maximizing + pressing play - worked. changing the window size pressing play.
minimizing, maximizing pressing play. no freeze.
my conclusios so far
BUT: that can't be the problem, because i did not even realize that the project froze until a friend that also works on the project wrote me about it.
also this is the second time i made these tests. last night i did all of this, too (adding cinemachine - freezing the editor multiple times, removing cinemachine still freezing, clearing caches and everything working fine again)
My System:
Core i5-4670K
GTX 970
16GB DDR 3 RAM
MSI Z87-G43
Windows 10 Pro (version 1803)
I used the package manager to import Cinemachine 2.2.7
and tried some of the things that made the editor crash with Cinemachine 2.2.8. it was way harder to do that but after playing around with the follow / lookAt fields in the freeLook camera i managed to do it again.
also note: the rest of my computer responds just fine, its only unity that freezes.
also note: when unity freezes it has 0% CPU usage (and ~650 MB RAM). so it does not seem to be an infinite loop - maybe a deadlock?
again after removing the Cinemachine 2.2.7 gameobjects the editor is still freezing when adding/removing components
I removed the Package with the package manager. and it seemed stable at first, but i managed to crash it with multiple component changes
After that it seemed again stable, i could not crash it with GameObject/component changes. but i deleted the gizmos folder that cinemachine created and it crashed again.
I tried to crash it again with minimizing / maximizing the editor window or creating/deleting assets or changing components/game objects but no luck so far.
it seems to be stable again.
my conclusios so far
I installed the post processing package from the package manager. I added Volume and Layer to my camera fiddled a bit with components, pressed play and it crashed
my conclusios so far
I removed the Github plugin, and tried some of the things i did prior to freeze the Editor. and it seems to be stable for now.
my conclusios so far
but: i also use this plugin in another project where i have absolutely no issues at all.
I imported cinemachine 2.2.8 again (note, sometimes after installing it no Gizmos folder is created, but this is just a side note).
no freezes so far.
so it really is the Github plugin - but why does my other project work fine? i.d.k. but i will post an issue on the github plugins repository.
after sending the mail I readded the plugin to the project. it first seemed to be stable, but after restarting the editor, i wanted to change the branch, which the tool did not let me (so i did it manually on the command line) and i wanted to commit my testings but the commit button stayed disabled. so i did the commit manually. restarded unity and at this point i can reproduce the freezes again.
Expected behavior: Not Freezing, but instead playing the scene
Actual behavior: Untiy freezing
Reproduces how often: ~95-100%
Additional Information
The text was updated successfully, but these errors were encountered: