From e120777ee81def29fe8efdad72696ebe032e9545 Mon Sep 17 00:00:00 2001 From: Kendall Gassner Date: Fri, 29 Mar 2024 12:53:07 -0700 Subject: [PATCH 1/3] Apply suggestion from @kendallgassner --- test/test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test.js b/test/test.js index 33cecfd..712b7c2 100644 --- a/test/test.js +++ b/test/test.js @@ -127,7 +127,7 @@ describe('remote-input', function() { const result = new Promise(resolve => { remoteInput.addEventListener('remote-input-success', (event) => { resolve(event) - }, {once: true}) + input.dispatchEvent(new Event('change')) }) changeValue(input, 'test') From 7fdbaad2c1d160948fff2d98ebeb82e698d255b0 Mon Sep 17 00:00:00 2001 From: Kendall Gassner Date: Fri, 29 Mar 2024 13:20:13 -0700 Subject: [PATCH 2/3] Apply suggestions from code review --- test/test.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/test.js b/test/test.js index 712b7c2..06c4b76 100644 --- a/test/test.js +++ b/test/test.js @@ -127,7 +127,6 @@ describe('remote-input', function() { const result = new Promise(resolve => { remoteInput.addEventListener('remote-input-success', (event) => { resolve(event) - input.dispatchEvent(new Event('change')) }) changeValue(input, 'test') @@ -141,7 +140,7 @@ describe('remote-input', function() { function changeValue(input, value) { input.value = value - input.dispatchEvent(new Event('focus')) + input.dispatchEvent(new Event('change')) } function nextTick() { From b5e7c4fc53d37a5339552499addb5e8b2dfaf230 Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Fri, 29 Mar 2024 20:23:18 +0000 Subject: [PATCH 3/3] formatting --- test/test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test.js b/test/test.js index 06c4b76..81fb27c 100644 --- a/test/test.js +++ b/test/test.js @@ -127,6 +127,7 @@ describe('remote-input', function() { const result = new Promise(resolve => { remoteInput.addEventListener('remote-input-success', (event) => { resolve(event) + }) }) changeValue(input, 'test')