-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds custom avatar #1636
base: main
Are you sure you want to change the base?
Adds custom avatar #1636
Conversation
seems very promising. The MR will also give a more general solution to #281. However the way custom avatar uri was provided was as a member of the Account class, bond to a commit. Might need further review from the repo maintainer. |
08380c3
to
5c2e8ed
Compare
542078a
to
77d3bd9
Compare
@tmkx , Why this PR is still pending? My organization is using azure devops, does this PR work on azure devops? |
It's fully customizable, as well as can be used in azure. |
Is anyone still actively working on this? |
ea424f3
to
c573c3e
Compare
thanks @tmkx! @axosoft-ramint @eamodio just wondering if there's anything that needs to be done here before a review? cheers |
Is there any movement on this? I found issue #281 which is marked as closed but it seems to not function/there is no setting(?). I can't reply on the issue as it's marked as closed with no comments. This PR seems like a fix for it and it's been sitting for a while. |
Yes |
f991b4f
to
fc3de11
Compare
When the PR will be merged into the main branch? |
fc3de11
to
db8398a
Compare
ping @eamodio @d13 @axosoft-ramint |
db8398a
to
a98b182
Compare
Description
Allow custom avatar url rule, backward compatible.
"gitlens.remotes": [ { "domain": "gitlab.intranet.com", "type": "Custom", "name": "Company", "protocol": "https", "urls": { "repository": "https://gitlab.intranet.com/${repo}", "branches": "https://gitlab.intranet.com/${repo}/branches", "branch": "https://gitlab.intranet.com/${repo}/commits/${branch}", "commit": "https://gitlab.intranet.com/${repo}/commit/${id}", "file": "https://gitlab.intranet.com/${repo}?path=${file}${line}", "fileInBranch": "https://gitlab.intranet.com/${repo}/blob/${branch}/${file}${line}", "fileInCommit": "https://gitlab.intranet.com/${repo}/blob/${id}/${file}${line}", "fileLine": "#L${line}", "fileRange": "#L${start}-L${end}", + "avatar": "https://avatar.intranet.com/employee?username=${name}&size=${size}" } } ]
close #302
close #1036
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses