Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds custom avatar #1636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds custom avatar #1636

wants to merge 1 commit into from

Conversation

tmkx
Copy link

@tmkx tmkx commented Sep 13, 2021

Description

Allow custom avatar url rule, backward compatible.

 "gitlens.remotes": [
   {
     "domain": "gitlab.intranet.com",
     "type": "Custom",
     "name": "Company",
     "protocol": "https",
     "urls": {
       "repository": "https://gitlab.intranet.com/${repo}",
       "branches": "https://gitlab.intranet.com/${repo}/branches",
       "branch": "https://gitlab.intranet.com/${repo}/commits/${branch}",
       "commit": "https://gitlab.intranet.com/${repo}/commit/${id}",
       "file": "https://gitlab.intranet.com/${repo}?path=${file}${line}",
       "fileInBranch": "https://gitlab.intranet.com/${repo}/blob/${branch}/${file}${line}",
       "fileInCommit": "https://gitlab.intranet.com/${repo}/blob/${id}/${file}${line}",
       "fileLine": "#L${line}",
       "fileRange": "#L${start}-L${end}",
+      "avatar": "https://avatar.intranet.com/employee?username=${name}&size=${size}"
     }
   }
 ]

close #302
close #1036

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@xiaoas
Copy link

xiaoas commented Dec 27, 2021

seems very promising. The MR will also give a more general solution to #281.

However the way custom avatar uri was provided was as a member of the Account class, bond to a commit. Might need further review from the repo maintainer.

@manc-lx
Copy link

manc-lx commented Aug 10, 2022

@tmkx , Why this PR is still pending? My organization is using azure devops, does this PR work on azure devops?

@tmkx
Copy link
Author

tmkx commented Aug 10, 2022

@tmkx , Why this PR is still pending? My organization is using azure devops, does this PR work on azure devops?

It's fully customizable, as well as can be used in azure.

@nunnsy
Copy link

nunnsy commented Oct 19, 2022

Is anyone still actively working on this?

@nunnsy
Copy link

nunnsy commented Nov 9, 2022

thanks @tmkx! @axosoft-ramint @eamodio just wondering if there's anything that needs to be done here before a review? cheers

@John-Dean
Copy link

Is there any movement on this? I found issue #281 which is marked as closed but it seems to not function/there is no setting(?). I can't reply on the issue as it's marked as closed with no comments.

This PR seems like a fix for it and it's been sitting for a while.

Echoing what @nunnsy said; @tmkx is this ready for review?

@tmkx
Copy link
Author

tmkx commented Jan 19, 2023

@tmkx is this ready for review?

Yes

@baranwang
Copy link

When the PR will be merged into the main branch? @eamodio @d13

@tmkx tmkx force-pushed the feat/custom-avatar branch 2 times, most recently from f991b4f to fc3de11 Compare May 5, 2023 18:21
@latel
Copy link

latel commented Jul 12, 2023

When the PR will be merged into the main branch?

@baranwang
Copy link

ping @eamodio @d13 @axosoft-ramint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get avatar from user Get GitLab avatar by email
7 participants