Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3528 Change branch terminal-run commands into normal commands w/ proper error handling #3597

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

3528 Change branch terminal-run commands into normal commands w/ proper error handling #3597

wants to merge 4 commits into from
+244 −59

Conversation

sergiolms
Copy link
Contributor

Description

Part 2 including changes to branch delete.
Resolves #3528

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergiolms sergiolms self-assigned this Sep 20, 2024
@sergiolms sergiolms force-pushed the feature/#3528-part2_change_branch_into_normal_cmd branch 2 times, most recently from d2ada6c to 275d1f4 Compare September 26, 2024 14:56
@eamodio
Copy link
Member

eamodio commented Sep 26, 2024

@sergiolms Please apply similar changes from #3596 to this PR

@sergiolms sergiolms force-pushed the feature/#3528-part2_change_branch_into_normal_cmd branch 6 times, most recently from c6b352d to d3f465e Compare September 27, 2024 13:24
sergiolms and others added 4 commits September 27, 2024 15:54
@sergiolms
Adds branchCreate and branchRename methods
d2c6ebd
@eamodio @sergiolms
Refactors branch creation and renaming
aae8254 
 - Moves error handling outside of GitProviderService (to allow callers control over handling)
- Splits unified branch command into specific calls and makes them optional

Refs #3528
@sergiolms
add deleteBranch
c16510e
@sergiolms
add BranchError and BranchErrorReason
fb0d9ac
@sergiolms sergiolms force-pushed the feature/#3528-part2_change_branch_into_normal_cmd branch from d3f465e to fb0d9ac Compare September 27, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sergiolms sergiolms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change branch terminal-run commands into normal commands w/ proper error handling
2 participants
@sergiolms @eamodio