Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace react-firebaseui in demo app with a better-maintained package #555

Open
xaphod opened this issue Sep 18, 2022 · 1 comment
Open
Labels
help wanted Extra attention is needed

Comments

@xaphod
Copy link

xaphod commented Sep 18, 2022

I'm trying to clone the example and start from there. Am I doing it right?

tim$ npx create-next-app --example https://github.com/gladly-team/next-firebase-auth/tree/main/example newproject
Creating a new Next.js app in ....

Downloading files from repo https://github.com/gladly-team/next-firebase-auth/tree/main/example. This might take a moment.

Installing packages. This might take a couple of minutes.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: example@0.1.0
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   react@"18.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@">=15 <=17" from react-firebaseui@5.0.2
npm ERR! node_modules/react-firebaseui
npm ERR!   react-firebaseui@"^5.0.2" from the root project

This is Node 16 / npm 8.3

@kmjennison
Copy link
Contributor

@xaphod Ah, it looks like react-firebaseui doesn't yet support React 18:
firebase/firebaseui-web-react#165

It still works as expected in the example app, though (see live demo).

The react-firebaseui dependency isn't required to use next-firebase-auth. Here's someone's suggestion on just dropping it for the underlying firebaseui library:
firebase/firebaseui-web-react#173 (comment)

I think it makes sense for us to swap out react-firebaseui, too, given that it doesn't seem to be very actively maintained.

@kmjennison kmjennison changed the title create-next-app not working with example: react-firebaseui dependency issue? Replace react-firebaseui in demo app with a better-maintained package Sep 19, 2022
@kmjennison kmjennison added the help wanted Extra attention is needed label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants