You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With fs set to fat32, the partitions are not mounted after creating and formatting the partitions.
It use to work but then after a rebase, some few changes introduced the regression.
After investigation, I found the culprit commit :
commit 94fedb2
Date: Tue Mar 19 17:43:42 2024 +0000
actions: image-partition: enable creation of FAT{12|16|32} partitions
This one added more options when it comes to creating FAT partitions. So when partition fs is defined as "fat", "fat12", "fat16", "fat32", "msdos" or "vfat", then mkfs.vfat is used to create the partition, and different options were used depending on the FAT type.
The main issue is that mounting a FAT partition should use "vfat"
as fs type when using syscall.Mount().
So, in order to fix this issue, "vfat" is simply used to mount "fat", "fat12", "fat16", "fat32" or "msdos" partitions.
I created a pull request with a proposed fix here.
The text was updated successfully, but these errors were encountered:
The keywords 'fat32' or 'vfat' are equivalent, but due to a regression
in debos 1.1.4, using 'fat32' now leads to a build failure:
```
2024/05/27 07:44:27 ==== Setup the disk image ====
2024/05/27 07:44:27 Formatting partition 1 | mkfs.fat: Warning: lowercase labels might not work properly on some systems
2024/05/27 07:44:27 Formatting partition 1 | mkfs.fat 4.2 (2021-01-31)
[...]
2024/05/27 07:44:28 Action `recipe` failed at stage Run, error: esp mount failed: no such device
```
Upstream issues:
- go-debos/debos#500
- go-debos/debos#502
Assuming the following YAML section to generate the image :
With fs set to fat32, the partitions are not mounted after creating and formatting the partitions.
It use to work but then after a rebase, some few changes introduced the regression.
After investigation, I found the culprit commit :
commit 94fedb2
Date: Tue Mar 19 17:43:42 2024 +0000
actions: image-partition: enable creation of FAT{12|16|32} partitions
This one added more options when it comes to creating FAT partitions. So when partition fs is defined as "fat", "fat12", "fat16", "fat32", "msdos" or "vfat", then mkfs.vfat is used to create the partition, and different options were used depending on the FAT type.
The main issue is that mounting a FAT partition should use "vfat"
as fs type when using syscall.Mount().
So, in order to fix this issue, "vfat" is simply used to mount "fat", "fat12", "fat16", "fat32" or "msdos" partitions.
I created a pull request with a proposed fix here.
The text was updated successfully, but these errors were encountered: