Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove response bytes method in-favor Body field, cleanup, apply appropriate naming struct, methods #871

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jeevatkm
Copy link
Member

No description provided.

@jeevatkm jeevatkm added this to the v3.0.0 Milestone milestone Sep 26, 2024
@jeevatkm jeevatkm self-assigned this Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.45%. Comparing base (c6cf259) to head (abd8971).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
client.go 50.00% 0 Missing and 1 partial ⚠️
util_curl.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
+ Coverage   98.15%   98.45%   +0.29%     
==========================================
  Files          14       14              
  Lines        2329     2325       -4     
==========================================
+ Hits         2286     2289       +3     
+ Misses         23       19       -4     
+ Partials       20       17       -3     
Flag Coverage Δ
unittests 98.45% <90.90%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit 386a336 into main Sep 26, 2024
3 of 4 checks passed
@jeevatkm jeevatkm deleted the refactor-optimize-cleanup branch September 26, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant