-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Simple Todo] - API 11 #5005
base: main
Are you sure you want to change the base?
[Simple Todo] - API 11 #5005
Conversation
- Update to API 11
Outdated attemptAll builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it! The average merge time for plugin updates is currently 3 hours.
1 hidden need (known safe NuGet packages).Show log - Review |
Please update the version of your plugin - happy to merge once that's done 🙂 |
Oooh the fourth number doesn't suffice apparently :D Well, I guess I'll just remove that one then. Sorry for the inconvenience |
- Versionbump to 0.0.2
Head branch was pushed to by a user without write access
bleatbot, rebuild |
All builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
1 hidden need (known safe NuGet packages).Show log - Review |
You're only modifying the plugin json manifest, not the csproj where it should be defined. (You don't actually need to set the AssemblyVersion, ApplicableVersion, or DalamudApiLevel in your json. DalamudPackager will take care of filling those in for you! You'd wanna update the version number here: https://gitlab.com/moonfox-projects/simpletodo/-/blob/master/SimpleTodo/SimpleTodo.csproj?ref_type=heads#L14 (Looking at your csproj, you could also trim Author from your json too since you set that in the csproj) |
Update to API 11
This includes literally just the change from 10 to 11 in the plugin's json config and the SDK update :D
Thanks for your work <3