Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simple Todo] - API 11 #5005

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Simple Todo] - API 11 #5005

wants to merge 2 commits into from

Conversation

Lunalicious
Copy link
Contributor

Update to API 11

This includes literally just the change from 10 to 11 in the plugin's json config and the SDK update :D

Thanks for your work <3

- Update to API 11
@bleatbot bleatbot enabled auto-merge (squash) November 21, 2024 12:00
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 21, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 3 hours.

Name Commit Status
⚠️ SimpleTodo [stable] b21e111 Same version!!! v0.0.1.0 - Diff (5 lines, prev. 0.0.1.0) - Semantic
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added version conflict This plugin was built with a lower or the same version. size-small Diff for this PR is small. labels Nov 21, 2024
@philpax
Copy link
Contributor

philpax commented Nov 21, 2024

Please update the version of your plugin - happy to merge once that's done 🙂

@Lunalicious
Copy link
Contributor Author

Oooh the fourth number doesn't suffice apparently :D Well, I guess I'll just remove that one then. Sorry for the inconvenience

- Versionbump to 0.0.2
auto-merge was automatically disabled November 22, 2024 18:56

Head branch was pushed to by a user without write access

@goaaats
Copy link
Member

goaaats commented Nov 23, 2024

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
⚠️ SimpleTodo [stable] 95f85fa Same version!!! v0.0.1.0 - Diff (5 lines, prev. 0.0.1.0) - Semantic
1 hidden need (known safe NuGet packages).
Show log - Review

@reiichi001
Copy link
Contributor

You're only modifying the plugin json manifest, not the csproj where it should be defined. (You don't actually need to set the AssemblyVersion, ApplicableVersion, or DalamudApiLevel in your json. DalamudPackager will take care of filling those in for you!

You'd wanna update the version number here: https://gitlab.com/moonfox-projects/simpletodo/-/blob/master/SimpleTodo/SimpleTodo.csproj?ref_type=heads#L14

(Looking at your csproj, you could also trim Author from your json too since you set that in the csproj)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-small Diff for this PR is small. version conflict This plugin was built with a lower or the same version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants