Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider storing jobs without the job ID in the option name #232

Open
bekarice opened this issue Aug 25, 2017 · 0 comments
Open

Consider storing jobs without the job ID in the option name #232

bekarice opened this issue Aug 25, 2017 · 0 comments
Labels
Background Jobs Code concerning background jobs Feature

Comments

@bekarice
Copy link
Contributor

Since we don't leverage the WP core get|update_option methods any longer, we don't necessarily need the unique job identifier in the option name. This causes issues on some hosts that artificially limit the options table to 64 characters rather than the default 255 since WP 4.4.

We can consider storing the job ID as part of the job data instead, then adjusting our SQL to look for this ID when getting the job since the option names will be duplicated.

Will also need an upgrade in plugins that implement this for the existing job storage. This can be used as a stop-gap until considering whether or not we want to move job storage to a custom table.

@bekarice bekarice added Background Jobs Code concerning background jobs Feature labels Aug 25, 2017
@ChaseWiseman ChaseWiseman added this to the v5.3.0 milestone Dec 2, 2017
@ChaseWiseman ChaseWiseman removed this from the v5.5.0 milestone Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Background Jobs Code concerning background jobs Feature
Projects
None yet
Development

No branches or pull requests

2 participants