Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ New PUBSUB - NATS JetStream support #1002

Closed
wants to merge 139 commits into from
Closed

✨ New PUBSUB - NATS JetStream support #1002

wants to merge 139 commits into from

Conversation

mfreeman451
Copy link
Contributor

@mfreeman451 mfreeman451 commented Sep 8, 2024 •
edited
Loading

Pull Request Template

Description:

  • Adding support for NATS JetStream message broker
  • NATS support  #584
  • Highlight the motivation behind the changes and the expected benefits.

Breaking Changes (if applicable):

N/A

Additional Information:

  • Using NATS JetStream API
  • Include screenshots or code snippets (if necessary) to clarify the changes.

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@mfreeman451 mfreeman451 marked this pull request as draft September 8, 2024 16:14
@aryanmehrotra
Copy link
Member

Hey, could you please check this out
https://github.com/gofr-dev/gofr/blob/development/pkg/gofr/datasource/README.md

It is mentioned to have a separate repo - but you can also create a separate package, the same way it is done for mongodb, cassandra...

this should be supported as an external package - such that users who are using it will only have it in the binary.

@mfreeman451
✅ adding message test
4b93955
@mfreeman451
🤡 added mocked jetstream
7991516
@mfreeman451
🚧 WIP natsclient test
9ebd1f7
@mfreeman451
✅ updated nats test
ba51980
@mfreeman451
🤡 added mocked nats connection
bc613e2
@mfreeman451
Merge branch 'development' into new/nats_jetstream_support
f8f97c7
@mfreeman451
🚨 fixing linter issues
a227f93
@mfreeman451
🐛 fixing kafka thing
2be4273
@mfreeman451
🔧 renaming NATSClient
5ed9e4e
@mfreeman451
✨ adding some missing files
52a77be
@mfreeman451
✅ updated tests
2e0feac
@mfreeman451
🚨 fixing linter issues
da70ca5
@mfreeman451
✨ adding go.mod
eb47ade
@mfreeman451
📝 updated docs for NATS
ab6d892
@mfreeman451
Merge branch 'development' into new/nats_jetstream_support
fb40358
@mfreeman451
👷‍♂️ WIP
d09e6c6
@mfreeman451
🚧 WIP
cad63b0
@mfreeman451
🚧 updating tests
96e38b6
@mfreeman451
🚧 fixing tests
097dcdd
@mfreeman451
✅ fixd subscribesuccess stuff
f3e678b
@mfreeman451
🚧 updating health tests
a18bfbb
@mfreeman451
✅ updated tests
fe1ce59
@mfreeman451
🚧 WIP example
c7ecc20
@mfreeman451
🔨 working out import cycle issues
0f781f9
@mfreeman451
✅ updated tests
691654d
@aryanmehrotra
Copy link
Member

@mfreeman451 any update on the issues?

Umang01-hash
Umang01-hash requested changes Oct 30, 2024
View reviewed changes
docs/advanced-guide/using-publisher-subscriber/page.md Show resolved Hide resolved
pkg/gofr/datasource/file/sftp/go.mod Outdated Show resolved Hide resolved
pkg/gofr/datasource/pubsub/nats/client.go Show resolved Hide resolved
pkg/gofr/datasource/pubsub/nats/client.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/pubsub/nats/committer.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/pubsub/nats/config.go Outdated Show resolved Hide resolved
@mfreeman451
Copy link
Contributor Author

Removing context support from my integration is unacceptable, I am closing this Pull Request and will maintain my own fork of the integration and gofr that uses contexts on Connect() methods.

@mfreeman451 mfreeman451 closed this Nov 5, 2024
@mfreeman451 mfreeman451 deleted the new/nats_jetstream_support branch November 5, 2024 14:15
@vipul-rawat vipul-rawat mentioned this pull request Nov 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Umang01-hash Umang01-hash Umang01-hash requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for NATS-KV (key-value) store
4 participants
@mfreeman451 @aryanmehrotra @Umang01-hash @vipul-rawat