Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] improve location tagging when creating a job #92

Open
ghost opened this issue Apr 19, 2023 · 8 comments
Open

[FEATURE] improve location tagging when creating a job #92

ghost opened this issue Apr 19, 2023 · 8 comments
Labels
backend beginner enhancement New feature or request ui UI/UX Issues ux

Comments

@ghost
Copy link

ghost commented Apr 19, 2023

  • add a new field in the job table called "detected_location_ids" this must be an array of strings, each string must be the key to seo_locations table
  • the same way we have when we create a new developer profile, we should be able to select one or more locations from a list and being able to remove them as shown in the video below
  • update the post-a-job.html/edit.html/manage.html pages to reflect this change
  • update handlers so that they get detected_location_ids
  • the location instead of being a simple free text string will be generated from the detected location ids, just concatenate them with a ", " eg. detected_location_ids: [Remote, Spain, Portugal], location = "Remote, Spain, Portugal"
  • update fixtures and schema
  • local testing
Screen.Recording.2023-04-19.at.17.37.58.mov
@ghost ghost added enhancement New feature or request ui UI/UX Issues ux beginner backend labels Apr 19, 2023
@congthang12312
Copy link

I want to take this!!

@ghost
Copy link
Author

ghost commented Apr 22, 2023

@congthang12312 I have seen you commented on another issue also, please work on one item at a time, feel free to open a Draft PR for whichever issue you want to work on and I will assign to you

@congthang12312
Copy link

Sure!

@congthang12312
Copy link

Hi @dm161 I try to push the commit into repo. But I don't have permission. Can help me check this?
image

@congthang12312
Copy link

@dm161 why we need a new detected_location_ids in job table? I see in job table already have location field. What is the different?

@ghost
Copy link
Author

ghost commented Apr 22, 2023

Please create a fork

@ghost
Copy link
Author

ghost commented Apr 22, 2023

Detected location id is the primary key to the seo_locations table. Location is the “string” value. Have a look at the golang code

@menkotoglou
Copy link

Was this ever resolved? Any chance that I can have a look at it?

@algora-pbc algora-pbc bot removed the 💎 Bounty label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend beginner enhancement New feature or request ui UI/UX Issues ux
Projects
None yet
Development

No branches or pull requests

2 participants