x/sys/windows: signal.Notify doesn't handle windows.Signal well

[QianQQQ]

Go version

go version go1.22.3 windows/amd64

Output of go env in your module/workspace:

set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\qian\AppData\Local\go-build
set GOENV=C:\Users\qian\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\qian\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\qian\go
set GOPRIVATE=
set GOROOT=D:\Environments\go
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=D:\Environments\go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.22.3
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=0
set GOMOD=NUL
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\qian\AppData\Local\Temp\go-build3528663502=/tmp/go-build -gno-record-gcc-switches

What did you do?

When developing a server on Windows, we want to capture the SIGINT signal for extension purposes.
https://go.dev/play/p/wiNlThXDUPT

What did you see happen?

signal.Notify(c chan<- os.Signal, sig ...os.Signal) cannot correctly capture windows.Signal.

What did you expect to see?

signal.Notify can correctly handle windows.Signal.
This means that when pressing Ctrl+C, the logic can be correctly triggered.

[gabyhelp]

Related Issues

• os/signal: sometimes SIGINT is not delivered #21905 (closed)
• os: support Process.Signal(Interrupt) on Windows #46345 (closed)
• runtime: handling of CTRL_CLOSE_EVENT seems broken #41884 (closed)
• os,os/signal: documentation issue with Notify(), syscall.SIGTERM, and CTRL_CLOSE_EVENT/CTRL_LOGOFF_EVENT/CTRL_SHUTDOWN_EVENT #69847 (closed)
• os/signal: SIGTSTP can't be handled #41996 (closed)
• os/signal: SIGINT cannot be catched with cgo system("ls") call #26245 (closed)
• runtime/trace: Tracing error when catching SIGINT #57572
• Guaranty completion of signals handling #4347 (closed)

Related Code Changes

• runtime: treat CTRL_CLOSE_EVENT, CTRL_LOGOFF_EVENT, CTRL_SHUTDOWN_EVENT as SIGTERM on Windows

Related Discussions

• Possible bug in Windows os/signal

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/628275 mentions this issue: os/signal: check int type of signal using reflection

[cherrymui]

cc @golang/windows

[zigo101]

Missed "not" in title?