Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: reasonable not handling error on getting procject id from metadata server in google implementation? #751

Open
0daryo opened this issue Nov 11, 2024 · 0 comments · May be fixed by #752
Open

Question: reasonable not handling error on getting procject id from metadata server in google implementation? #751

0daryo opened this issue Nov 11, 2024 · 0 comments · May be fixed by #752

Comments

@0daryo
Copy link

0daryo commented Nov 11, 2024 •
edited
Loading

I found error on getting procject id is not handled. Is this has any reason?
I actually got empty project id and wanted to know detail reasons.

oauth2/google/default.go

Line 217 in 22134a4

id, _ := metadata.ProjectID()

If OK to handle. I can work on it.
@0daryo 0daryo changed the title Question: Is it reasonable to ignore error on getting procject id from metadata in google implementation Question: reasonable to ignore error on getting procject id from metadata server in google implementation? Nov 11, 2024
@0daryo 0daryo linked a pull request Nov 11, 2024 that will close this issue
Open
@0daryo 0daryo changed the title Question: reasonable to ignore error on getting procject id from metadata server in google implementation? Question: reasonable not handling error on getting procject id from metadata server in google implementation? Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handling error on getting project id from google metadata server 0daryo/oauth2
1 participant
@0daryo