-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polishing Go companion integration #3597
Comments
This is doable. In the current implementation there is a one-to-one correspondence between code lens and test item. Depending on the user's configuration, a test item may not exist for a given file or package. It may be best to implement these with a "run all tests in " command where the scope is a string (really: is not a test item) to push test item resolution onto the command implementation. IIRC, I chose not to implement "run file/packages tests" because it was a non-trivial amount of work and unclear if it was needed.
I'm not clear on what you mean by the "running test" progress status bar. Are you referring to a vscode-go status bar? If so, interacting with that from Go Companion would be tricky I think. |
Also:
|
Change https://go.dev/cl/628536 mentions this issue: |
Updates #3597 Change-Id: Ib6d6d30e7970a5b5581919fe58943346b355cf7d Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/628536 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Commit-Queue: Ethan Reesor <ethan.reesor@gmail.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
I added a workflow that publishes the extension when I push a tag |
cc @firelizzard18
The text was updated successfully, but these errors were encountered: