Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing Go companion integration #3597

Open
6 of 7 tasks
hyangah opened this issue Nov 11, 2024 · 4 comments
Open
6 of 7 tasks

Polishing Go companion integration #3597

hyangah opened this issue Nov 11, 2024 · 4 comments
Assignees
Labels
Go Companion Issues relating to the Go Companion extension go-test issues related to go test support (test output, test explorer, ...)

Comments

@hyangah
Copy link
Contributor

hyangah commented Nov 11, 2024

  • The legacy code lens had package-level and file-level tests codelenses placed around the "package" directive. Reevaluate if we want them in the Go Companion.
  • Disable the vscode-go extension's code lenses when the Go Companion extension is active.
  • Consider the "running test" progress status bar when triggering a test run using the code lens. After clicking the codelens, it's not very clear whether the test is running or not. (the gutter icon had changed, but it's easy to catch)
  • Code coverage view: skip or correctly link files in stdlib or dependency modules.
  • Document settings in the package.json so the details show up in the settings doc correctly.
  • Go Companion v0.0.3 release for the coverage, and profile supports
  • Release process transparency - I think the easiest is to use the github code action.

cc @firelizzard18

@hyangah hyangah added go-test issues related to go test support (test output, test explorer, ...) Go Companion Issues relating to the Go Companion extension labels Nov 11, 2024
@gopherbot gopherbot added this to the Untriaged milestone Nov 11, 2024
@firelizzard18
Copy link
Contributor

firelizzard18 commented Nov 11, 2024

The legacy code lens had package-level and file-level tests codelenses placed around the "package" directive. Reevaluate if we want them in the Go Companion.

This is doable. In the current implementation there is a one-to-one correspondence between code lens and test item. Depending on the user's configuration, a test item may not exist for a given file or package. It may be best to implement these with a "run all tests in " command where the scope is a string (really: is not a test item) to push test item resolution onto the command implementation. IIRC, I chose not to implement "run file/packages tests" because it was a non-trivial amount of work and unclear if it was needed.

Consider the "running test" progress status bar when triggering a test run using the code lens. After clicking the codelens, it's not very clear whether the test is running or not.

I'm not clear on what you mean by the "running test" progress status bar. Are you referring to a vscode-go status bar? If so, interacting with that from Go Companion would be tricky I think.

@firelizzard18
Copy link
Contributor

Also:

  • Improve Go Companion's test coverage

@firelizzard18 firelizzard18 self-assigned this Nov 13, 2024
firelizzard18 added a commit to firelizzard18/exp-vscode-go that referenced this issue Nov 13, 2024
@firelizzard18 firelizzard18 moved this to In Progress in Testing UI Renewal Nov 13, 2024
@h9jiang h9jiang modified the milestones: Untriaged, vscode-go/backlog Nov 14, 2024
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/628536 mentions this issue: extension/src: disable code lenses when Go Companion is active

firelizzard18 added a commit to firelizzard18/exp-vscode-go that referenced this issue Nov 16, 2024
firelizzard18 added a commit to firelizzard18/exp-vscode-go that referenced this issue Nov 16, 2024
firelizzard18 added a commit to firelizzard18/exp-vscode-go that referenced this issue Nov 16, 2024
firelizzard18 added a commit to firelizzard18/exp-vscode-go that referenced this issue Nov 16, 2024
gopherbot pushed a commit that referenced this issue Nov 18, 2024
Updates #3597

Change-Id: Ib6d6d30e7970a5b5581919fe58943346b355cf7d
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/628536
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Commit-Queue: Ethan Reesor <ethan.reesor@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
@firelizzard18
Copy link
Contributor

I added a workflow that publishes the extension when I push a tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go Companion Issues relating to the Go Companion extension go-test issues related to go test support (test output, test explorer, ...)
Projects
Status: In Progress
Development

No branches or pull requests

4 participants