Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gazelle naming convention changes #717

Open
lijunsong opened this issue Jun 30, 2023 · 0 comments
Open

gazelle naming convention changes #717

lijunsong opened this issue Jun 30, 2023 · 0 comments

Comments

@lijunsong
Copy link

Hello, go-jsonnet is still using gazelle 0.26, which generates old-style BUILD target names. For projects using newer gazelle, the default naming convention for go-jsonnet is "@com_github_google_go_jsonnet//:go-jsonnet".

Of course a small tune is possible: simply tune the build_naming_convention argument:

    go_repository(
        name = "com_github_google_go_jsonnet",
        build_naming_convention = "go_default_library",
        importpath = "github.com/google/go-jsonnet",
        sum = "h1:WG4TTSARuV7bSm4PMB4ohjxe33IHT5WVTrJSU33uT4g=",
        version = "v0.20.0",
    )

A better fix would be similar to google/rpmpack#59, upgrade gazelle, generate the BUILD file again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant