Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloning should avoid validation checks #60

Open
rakudrama opened this issue Jul 21, 2016 · 0 comments · May be fixed by #661
Open

Cloning should avoid validation checks #60

rakudrama opened this issue Jul 21, 2016 · 0 comments · May be fixed by #661
Labels
perf Related to runtime performance

Comments

@rakudrama
Copy link
Contributor

When merging data from the same field (i.e. identical FieldInfo) we can avoid validation checks because the source must already have been validated. This will be especially beneficial for repeated fields.
sigurdm pushed a commit to sigurdm/protobuf that referenced this issue Dec 10, 2018
@jakobr-google
Merge pull request google#60 from dart-lang/tweaks
d5b3171 
Tweaks
@osa1 osa1 added the perf Related to runtime performance label May 11, 2022
osa1 added a commit to osa1/protobuf.dart that referenced this issue May 24, 2022
@osa1
Implement fast path when merging fields of same message
a0976da 
Fixes google#60
@osa1 osa1 linked a pull request May 24, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
perf Related to runtime performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expect same message types in mergeFromMessage osa1/protobuf.dart
2 participants
@osa1 @rakudrama