Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should generated classes be final? #820

Open
srawlins opened this issue Apr 18, 2023 · 1 comment
Open

Should generated classes be final? #820

srawlins opened this issue Apr 18, 2023 · 1 comment

Comments

@srawlins
Copy link
Contributor

I don't super duper use protobuf-generated classes, but I suspect users would benefit from them being final. They can get improved static analysis like understanding that two objects of two different final class can never be equal, or for exhaustiveness purposes, etc.

@srawlins
Copy link
Contributor Author

I did an internal audit showing that making proobuf enum classes final would not be breaking 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant