You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice if comments on rpc:s in the proto files were passed on as comments on generated method stubs. It would also be nice if option deprecated = true resulted in a @Deprecated annotation. Currently none of these things happen; for example,
This implements generating doc comments for enum types, enum values, rpc types,
and rpc methods.
Existing code for generating doc comments is refactored: the comment generator
handles trailing whitespace so we don't have to handle it in the call sites.
Comment generator is documented with the invariants: it never returns an empty
string (returns `null` instead) and never returns lines with trailing
whitespace.
To be able to test comment generating, a new kind of golden file test is added.
The difference from the other golden file tests is that this file is compiled
from .proto source instead of from a hand-crafted descriptor. This is because
attaching comments to proto field and types by hand is difficult and error
prone.
Fixes the comment part of #900.
It would be nice if comments on rpc:s in the proto files were passed on as comments on generated method stubs. It would also be nice if
option deprecated = true
resulted in a@Deprecated
annotation. Currently none of these things happen; for example,generates as
which the client has no idea is deprecated, and gets no guidance from a comment.
The text was updated successfully, but these errors were encountered: