Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of secret-manager while using weather-dl for license keys. #368

Open
dabhicusp opened this issue Jul 26, 2023 · 1 comment · May be fixed by #374
Open

Make use of secret-manager while using weather-dl for license keys. #368

dabhicusp opened this issue Jul 26, 2023 · 1 comment · May be fixed by #374

Comments

@dabhicusp
Copy link
Collaborator

dabhicusp commented Jul 26, 2023

As part of our current data download process for the weather-dl, we are not using secret-manager services. This poses a potential security risk, as the sensitive configuration data stored in the config file could be inadvertently leaked, resulting in public access to our API keys and other credentials.

To ensure the security of our licenses and sensitive configuration data, we should integrate the Secret Manager service into the weather-dl application. This will allow us to securely manage and retrieve API keys, URLs, and other credentials used during the data download process.

@dabhicusp dabhicusp changed the title Make use of [secret-manager](https://cloud.google.com/secret-manager) while using weather-dl for license keys. Make use of secret-manager while using weather-dl for license keys. Jul 26, 2023
@alxmrs
Copy link
Collaborator

alxmrs commented Jul 26, 2023

Duplicate of #12. Either way, I'm really happy to see this change in weather-dl -- thanks for creating the issue (and working on this).

@dabhicusp dabhicusp linked a pull request Jul 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants