Plugin won't work with require.js

[DoomTay]

The page will attempt to load %PATH%/video.js, which will fail, and the console will give the error Script error for "video.js", needed by: ima.

Even if a script was successfully retrieved, the console will instead give the error player.ima is not a function.

Thankfully, the fix appears to be simple; references to require('video.js') and define(['video.js'], factory) need to be changed to videojs.

Here is a minimal test case and the result of the above fix

[shawnbuso]

Thanks for the thorough debugging info - I'll try out this change and make sure it doesn't affect our non-require.js set-ups.

[DoomTay]

According to videojs/videojs-contrib-ads#399 (comment) the actual fix might involve something completely different

[Kiro705]

Hi @DoomTay, was this issue resolved through videojs-contrib-ads or is it something that still requires attention for the videojs-ima team?

I'm going to close this issue but please reopen if it is something we can work on.