Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overhaul of server streaming retries #1653

Merged
merged 106 commits into from
Sep 24, 2024
Merged

fix: overhaul of server streaming retries #1653

merged 106 commits into from
Sep 24, 2024

Commits on Aug 1, 2024

  1. fix: reduce duplicate code in streaming retries and add a test

    @leahecole
    leahecole committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0f9988a View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. add comments

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6d1841f View commit details
    Browse the repository at this point in the history

  2. WIP experiment

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    23ef391 View commit details
    Browse the repository at this point in the history

  3. experiments

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6a3552e View commit details
    Browse the repository at this point in the history

  4. WIP - loss example

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ff26514 View commit details
    Browse the repository at this point in the history

  5. fix typo, use pipe not pumpify

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ce6ef1c View commit details
    Browse the repository at this point in the history

  6. example of piping errors together

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    2b500f8 View commit details
    Browse the repository at this point in the history

  7. pipeline example

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    1a587c8 View commit details
    Browse the repository at this point in the history

  8. experiment continued

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    b4066e5 View commit details
    Browse the repository at this point in the history

  9. no buffer, data loss

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6fd50ad View commit details
    Browse the repository at this point in the history

  10. stream pipeline example

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8c5cb44 View commit details
    Browse the repository at this point in the history

  11. example that shows before and after

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8462d22 View commit details
    Browse the repository at this point in the history

  12. set immediate exampel

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    fd1a305 View commit details
    Browse the repository at this point in the history

  13. call both tests

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    abae9eb View commit details
    Browse the repository at this point in the history

  14. another scenario

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    416c167 View commit details
    Browse the repository at this point in the history

  15. more experiment

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0678f91 View commit details
    Browse the repository at this point in the history

  16. more experimentation

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4533036 View commit details
    Browse the repository at this point in the history

  17. more experimenting

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    cbd38bc View commit details
    Browse the repository at this point in the history

  18. some reorganization

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    90961b7 View commit details
    Browse the repository at this point in the history

  19. more experiments

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    1644761 View commit details
    Browse the repository at this point in the history

  20. WIP: more exampels

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e163c4e View commit details
    Browse the repository at this point in the history

  21. WIP

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    47fd5a8 View commit details
    Browse the repository at this point in the history

  22. WIP: fixing tests

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3c09df7 View commit details
    Browse the repository at this point in the history

  23. move streamingRetryRequest to streaming.ts, remove delayStream

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    659a0f5 View commit details
    Browse the repository at this point in the history

  24. WIP - move SRR into streamProxy class

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    f9ac498 View commit details
    Browse the repository at this point in the history

  25. WIP - reduce duplicate code between forwardEventsREtries and streamin… 

    …gErrorhanodffhandler
    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6cbe715 View commit details
    Browse the repository at this point in the history

  26. WIP - exploration of SRR removal

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    783f2f1 View commit details
    Browse the repository at this point in the history

  27. merge with cbt2

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    035025c View commit details
    Browse the repository at this point in the history

  28. fix mistake from rebase

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e31781a View commit details
    Browse the repository at this point in the history

  29. Merge remote-tracking branch 'origin' into cbt2

    @leahecole
    leahecole committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3421457 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. wip - remove bind from non error emit

    @leahecole
    leahecole committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    bb92ac5 View commit details
    Browse the repository at this point in the history

  2. WIP - stream retries pipeline - success case

    @leahecole
    leahecole committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    61c3e27 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. WIP - redoing SRR, successful calls

    @leahecole
    leahecole committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    68b4814 View commit details
    Browse the repository at this point in the history

  2. wip - redoing retries, fails immediately

    @leahecole
    leahecole committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1f4d845 View commit details
    Browse the repository at this point in the history

  3. WIP - some retrying

    @leahecole
    leahecole committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    cf61b49 View commit details
    Browse the repository at this point in the history

  4. WIP - theoretically working

    @leahecole
    leahecole committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    5df8279 View commit details
    Browse the repository at this point in the history

  5. some test cleanup

    @leahecole
    leahecole committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    57fe9da View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. WIP

    @leahecole
    leahecole committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c221dc7 View commit details
    Browse the repository at this point in the history

  2. WIP

    @leahecole
    leahecole committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bfb7f97 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:googleapis/gax-nodejs into cbt2

    @leahecole
    leahecole committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e522f74 View commit details
    Browse the repository at this point in the history

  4. WIP - resetting retries to zero

    @leahecole
    leahecole committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bd6ae25 View commit details
    Browse the repository at this point in the history

  5. change .end to .destroy

    @leahecole
    leahecole committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    a9ac063 View commit details
    Browse the repository at this point in the history

  6. Working version of new retries

    @leahecole
    leahecole committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b7cdeca View commit details
    Browse the repository at this point in the history

  7. linted test app

    @leahecole
    leahecole committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    021cfd3 View commit details
    Browse the repository at this point in the history

  8. WIP - no lint errors, but lots commented out

    @leahecole
    leahecole committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    7a466ef View commit details
    Browse the repository at this point in the history

  9. cleanup

    @leahecole
    leahecole committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    eda25aa View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. remove files that shouldn't be here

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    036b4a6 View commit details
    Browse the repository at this point in the history

  2. remove files

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4cd45ea View commit details
    Browse the repository at this point in the history

  3. remove protos that don't need to be there

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    67836de View commit details
    Browse the repository at this point in the history

  4. remove more files

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0829c67 View commit details
    Browse the repository at this point in the history

  5. remove text files

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f993c06 View commit details
    Browse the repository at this point in the history

  6. more cleanup

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c710a15 View commit details
    Browse the repository at this point in the history

  7. remove more files

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    04f4ff7 View commit details
    Browse the repository at this point in the history

  8. remove old directories

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1800589 View commit details
    Browse the repository at this point in the history

  9. finish file cleanup

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5eb5a3c View commit details
    Browse the repository at this point in the history

  10. more cleanup

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    04338d4 View commit details
    Browse the repository at this point in the history

  11. fix one unit test

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b3e9e54 View commit details
    Browse the repository at this point in the history

  12. fix some unit tests

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1a6237b View commit details
    Browse the repository at this point in the history

  13. revert previous change

    @leahecole
    leahecole committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    de35694 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. fix some unit tests

    @leahecole
    leahecole committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    cf189cb View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. fix another unit test

    @leahecole
    leahecole committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    b03fbae View commit details
    Browse the repository at this point in the history

  2. fix one more unit test

    @leahecole
    leahecole committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    9e69b2c View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. WIP - event forwarding is working!

    @leahecole
    leahecole committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4f56355 View commit details
    Browse the repository at this point in the history

  2. fix test behavior - move data push inside of case

    @leahecole
    leahecole committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3658772 View commit details
    Browse the repository at this point in the history

  3. WIP - fixing shouldRetry test

    @leahecole
    leahecole committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    97fa51a View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. fix another unit test

    @leahecole
    leahecole committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fe09b9f View commit details
    Browse the repository at this point in the history

  2. fix another unit test

    @leahecole
    leahecole committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9c7f1c5 View commit details
    Browse the repository at this point in the history

  3. fix two more tests

    @leahecole
    leahecole committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    3131f92 View commit details
    Browse the repository at this point in the history

  4. fix more unit tests, remove console logs

    @leahecole
    leahecole committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    90b8cc5 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. WIP - trying final test again

    @leahecole
    leahecole committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a52f87d View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. add a lil stream destruction

    @leahecole
    leahecole committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b3dc0c8 View commit details
    Browse the repository at this point in the history

  2. WIP - update returns in inner function

    @leahecole
    leahecole committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    40c486d View commit details
    Browse the repository at this point in the history

  3. remove return

    @leahecole
    leahecole committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    524ec6c View commit details
    Browse the repository at this point in the history

  4. add status/end boolean, remove retrying boolean

    @leahecole
    leahecole committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    550c391 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. some testing fixes

    @leahecole
    leahecole committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    dfe6653 View commit details
    Browse the repository at this point in the history

  2. more fixes

    @leahecole
    leahecole committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    44c59d4 View commit details
    Browse the repository at this point in the history

  3. lots of lint fixes

    @leahecole
    leahecole committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    d0b979e View commit details
    Browse the repository at this point in the history

  4. fix todos, fix test behavior

    @leahecole
    leahecole committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    2c8460c View commit details
    Browse the repository at this point in the history

  5. some lint fixes, some todo cleanups

    @leahecole
    leahecole committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5785b0e View commit details
    Browse the repository at this point in the history

  6. resolve some todos

    @leahecole
    leahecole committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0d4c2da View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. add a test, todo cleanup

    @leahecole
    leahecole committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    40730d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. WIP - timeout stuff

    @leahecole
    leahecole committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9726e19 View commit details
    Browse the repository at this point in the history

  2. Timeout test

    @leahecole
    leahecole committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f6b47fa View commit details
    Browse the repository at this point in the history

  3. lint fixes

    @leahecole
    leahecole committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    500f9d9 View commit details
    Browse the repository at this point in the history

  4. remove retries param

    @leahecole
    leahecole committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6c9f92d View commit details
    Browse the repository at this point in the history

  5. helper function

    @leahecole
    leahecole committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8fcb6be View commit details
    Browse the repository at this point in the history

  6. resolving todos

    @leahecole
    leahecole committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    20529ea View commit details
    Browse the repository at this point in the history

  7. resolve lint

    @leahecole
    leahecole committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7a8af41 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Merge branch 'main' of github.com:googleapis/gax-nodejs into cbt2

    @leahecole
    leahecole committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e7ffe0d View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. clean up tests

    @leahecole
    leahecole committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0121d71 View commit details
    Browse the repository at this point in the history

  2. final fix of tests

    @leahecole
    leahecole committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    2a4e6bc View commit details
    Browse the repository at this point in the history

  3. re-add accidentally deleted file

    @leahecole
    leahecole committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    70ea6aa View commit details
    Browse the repository at this point in the history

  4. remove erroneous print statement

    @leahecole
    leahecole committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    789a1b4 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. private function

    @leahecole
    leahecole committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b186f69 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. address review comment

    @leahecole
    leahecole committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fae0c03 View commit details
    Browse the repository at this point in the history

  2. fixing docstring

    @leahecole
    leahecole committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ae95d4c View commit details
    Browse the repository at this point in the history

  3. fix lint

    @leahecole
    leahecole committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4370e53 View commit details
    Browse the repository at this point in the history

  4. add comments in test

    @leahecole
    leahecole committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d8abbc0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. type coercion change

    @leahecole
    leahecole committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9b3ac82 View commit details
    Browse the repository at this point in the history

  2. resolve review comment

    @leahecole
    leahecole committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1095232 View commit details
    Browse the repository at this point in the history

  3. better typing in unit tests

    @leahecole
    leahecole committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5f70f80 View commit details
    Browse the repository at this point in the history

  4. fix lint

    @leahecole
    leahecole committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ff7f29f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge branch 'main' into cbt2

    @leahecole
    leahecole committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ff0b5a1 View commit details
    Browse the repository at this point in the history

  2. fix - make sure package.json matches main

    @leahecole
    leahecole committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    face12f View commit details
    Browse the repository at this point in the history

  3. try/catch for timeout test

    @leahecole
    leahecole committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8dc2109 View commit details
    Browse the repository at this point in the history

  4. fix lint

    @leahecole
    leahecole committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7b577f0 View commit details
    Browse the repository at this point in the history