Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fails with go 1.23 due to panic in pyroscope-go/godeltaprof v0.1.7 #1874

Closed
Antiz96 opened this issue Sep 3, 2024 · 1 comment
Closed

Comments

@Antiz96
Copy link

Antiz96 commented Sep 3, 2024

Describe the bug
Building grafana-zabbix with go 1.23 and running tests fails with

panic: pattern "GET /debug/pprof/" (registered at /usr/local/go/src/net/http/pprof/pprof.go:100) conflicts with pattern "/debug/pprof/delta_heap" (registered at /go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.7/http/pprof/pprof.go:24):

	GET /debug/pprof/ matches fewer methods than /debug/pprof/delta_heap, but has a more general path pattern

This is due to a panic on go 1.23 in pyroscope-go/godeltaprof
Related upstream issue: grafana/pyroscope-go#118

Expected behavior
Tests pass without panic

Screenshots
NA

Network data
NA

Software versions

NA

I opened a PR to fix this at #1875

@ivanahuckova
Copy link
Member

fixed by #1877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

2 participants