Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: change nvmrc to 18 #1704

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Chore: change nvmrc to 18 #1704

merged 1 commit into from
Oct 9, 2023

Conversation

zoltanbedi
Copy link
Member

No description provided.

@zoltanbedi zoltanbedi requested a review from a team as a code owner October 6, 2023 14:18
@zoltanbedi zoltanbedi requested review from gabor and gwdawson and removed request for a team October 6, 2023 14:18
@zoltanbedi zoltanbedi self-assigned this Oct 6, 2023
gabor
gabor approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zoltanbedi zoltanbedi merged commit 746e073 into master Oct 9, 2023
1 check passed
@zoltanbedi zoltanbedi deleted the zoltan/change-nvmrc-to-18 branch October 9, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor gabor gabor approved these changes

@gwdawson gwdawson Awaiting requested review from gwdawson gwdawson was automatically assigned from grafana/oss-big-tent

Assignees

@zoltanbedi zoltanbedi

Labels
None yet
Projects
OSS Big Tent
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoltanbedi @gabor