Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is DatabaseService needed? #15

Open
Nyholm opened this issue Oct 29, 2016 · 1 comment
Open

Why is DatabaseService needed? #15

Nyholm opened this issue Oct 29, 2016 · 1 comment

Comments

@Nyholm
Copy link
Contributor

Nyholm commented Oct 29, 2016

Why is the GraphAware\Reco4PHP\Persistence\DatabaseService needed? (source)

It works as a wrapper for the ClientBuilder. Wouldn't it be simpler to typehint for a ClientInterace directly. That would remove an unneeded abstraction layer.
@ikwattro
Copy link
Member

The initial idea was to make it compatible with other graph dbs in the future, but I completely forgot this idea. So yes it makes sense to just have a typhint on ClientInterface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ikwattro @Nyholm