Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] program termination #22

Closed
hopeyen opened this issue Sep 19, 2023 · 0 comments · Fixed by #24
Closed

[Bug] program termination #22

hopeyen opened this issue Sep 19, 2023 · 0 comments · Fixed by #24
Assignees
Labels
meta:triaged This issue has been triaged (has a good description, as well as labels for priority, size and type) p2 Medium priority size:large Large type:bug Something isn't working type:spike Additional research required

Comments

@hopeyen
Copy link
Contributor

hopeyen commented Sep 19, 2023

Problem statement

Add graceful shutdown to the radio

Expectation proposal

The ideal process of shutting down

  • First the radio stops listening to waku signals: Graphcast agent's waku node should stop
  • message senders between Graphcast agent and radio operator should drop as the already received signals are processed
  • All graphcast gossip operations shut down
  • message processing should finish decoding, validating, and storing the messages
  • radio operations should stop
  • http server shuts down
  • metrics shuts down
  • program exits

Alternative considerations

This may fit better in the re-architecture of radios, but it is a good learning opportunity for fixing the current structure

@hopeyen hopeyen added type:bug Something isn't working size:large Large p2 Medium priority type:spike Additional research required labels Sep 19, 2023
@hopeyen hopeyen self-assigned this Sep 19, 2023
@nerium1918 nerium1918 added meta:awaiting-triage meta:triaged This issue has been triaged (has a good description, as well as labels for priority, size and type) and removed meta:awaiting-triage labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta:triaged This issue has been triaged (has a good description, as well as labels for priority, size and type) p2 Medium priority size:large Large type:bug Something isn't working type:spike Additional research required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants