Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data docs rendering bug for UnexpectedRowsExpectation #10547

Open
VolkovGeoPhy opened this issue Oct 22, 2024 · 6 comments
Open

data docs rendering bug for UnexpectedRowsExpectation #10547

VolkovGeoPhy opened this issue Oct 22, 2024 · 6 comments
Labels
backlog bug Bugs bugs bugs!

Comments

@VolkovGeoPhy
Copy link

Describe the bug
https://docs.greatexpectations.io/docs/core/customize_expectations/use_sql_to_define_a_custom_expectation done as it described here.
In any case it doesn't render it in correct way despite I can see correct results in json file.

To Reproduce
Create any custom expectation as it described here. build docs.

Expected behavior
A clear and concise description of what you expected to happen.

Environment (please complete the following information):

  • Operating System: Docker
  • Great Expectations Version: 1.1.3
  • Data Source: Redshift
  • Cloud environment: no

Additional context
Screenshot 2024-09-30 at 17 44 07

@adeola-ak
Copy link
Contributor

are you executing locally? can you share your script

@adeola-ak adeola-ak moved this from To Do to In progress in GX Core Issues Board Oct 24, 2024
@VolkovGeoPhy
Copy link
Author

VolkovGeoPhy commented Oct 25, 2024

I've tried it in two ways. Locally and via airflow DAG + s3 storages.

    class ExpectNoGeometriesIntersect(gx.expectations.UnexpectedRowsExpectation):
        unexpected_rows_query: str = batch_query
        description: str = "No geometries should intersect with each other."

    logger.info(f"query={batch_query}")

    register_expectation(ExpectNoGeometriesIntersect)
    expectation = ExpectNoGeometriesIntersect()

    regular_suite.add_expectation(expectation)

@VolkovGeoPhy
Copy link
Author

The issue exits in 1.2.0 as well @adeola-ak. Let me know if you need some additional info.

@adeola-ak adeola-ak added the bug Bugs bugs bugs! label Oct 25, 2024
@adeola-ak
Copy link
Contributor

hi there @VolkovGeoPhy thanks for reporting this. I was able to reproduce. I will escalate this and follow up with you shortly

@adeola-ak
Copy link
Contributor

Hi there,

This issue has been added to our backlog, and our team will work on it, though we don’t have a timeline yet. If it’s something you’d like to see resolved sooner, you’re more than welcome to submit a contribution. Otherwise, please feel free to continue to check this issue for updates. Thank you!

@adeola-ak adeola-ak moved this from In progress to To Do in GX Core Issues Board Nov 6, 2024
@iamamutt
Copy link

I found that if I didn't set the description field in the expectation config then the content renders correctly. This seems to be the case not just for UnexpectedRowsExpectation but other types of expectation classes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog bug Bugs bugs bugs!
Projects
Status: To Do
Development

No branches or pull requests

3 participants