Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

82 dependency injection with autofac 2 #118

Merged
merged 7 commits into from
Jan 23, 2024
Merged

82 dependency injection with autofac 2 #118

merged 7 commits into from
Jan 23, 2024

Conversation

gregyjames
Copy link
Owner

Description

Implement dependency injection with AutoFac.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 17, 2024
View reviewed changes
OctaneTestProject/EqualityTest.cs Fixed Show fixed Hide fixed
OctaneTestProject/EqualityTest.cs Fixed Show fixed Hide fixed
OctaneTester/Examples/Autofac.cs Fixed Show fixed Hide fixed
OctaneTester/Examples/Autofac.cs Fixed Show fixed Hide fixed
OctaneTester/Examples/Autofac.cs Fixed Show fixed Hide fixed
OctaneEngine/Engine.cs Fixed Show fixed Hide fixed
OctaneTestProject/DownloadTest.cs Fixed Show fixed Hide fixed
OctaneTestProject/PauseResumeTest.cs Fixed Show fixed Hide fixed
OctaneTester/Examples/Autofac.cs Fixed Show fixed Hide fixed
OctaneTester/Examples/NoLogger.cs Fixed Show fixed Hide fixed
@gregyjames gregyjames linked an issue Jan 17, 2024 that may be closed by this pull request
Dependency Injection with Autofac #82
Closed
@gregyjames gregyjames added enhancement dependencies Pull requests that update a dependency file labels Jan 17, 2024
@gregyjames gregyjames force-pushed the 82-dependency-injection-with-autofac-2 branch from ab2707e to 8f517d4 Compare January 23, 2024 04:23
@gregyjames gregyjames merged commit d63c9ca into master Jan 23, 2024
6 of 7 checks passed
@Hawxy
Copy link

Hawxy commented Jan 23, 2024

I saw this come up in my feed and am a little dumbfounded by it. Autofac shouldn't be a hard dependency, as most people aren't using it. Ideally, you'd only be taking a dependency on Microsoft.Extensions.DependencyInjection.Abstractions and then let the callers decide what container to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregyjames gregyjames

Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency Injection with Autofac
2 participants
@gregyjames @Hawxy