Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] concurrent map writes in trackFeatureUsage #23

Open
tsurunoyu opened this issue Dec 13, 2023 · 0 comments · May be fixed by #26
Open

[Bug] concurrent map writes in trackFeatureUsage #23

tsurunoyu opened this issue Dec 13, 2023 · 0 comments · May be fixed by #26
Labels
bug Something isn't working

Comments

@tsurunoyu
Copy link

Summary

Using v0.1.9, we are seeing concurrent map write panics in trackFeatureUsage.

This is happening here:

gb.inner.trackedFeatures[key] = res.Value

The callers of trackFeatureUsage seem to have acquired read locks, but nothing is stopping multiple callers from trying to write to this map at the same time.

Expected Behavior

No panic.

Current Behavior

Under load, fetching feature flags via EvalFeature results in a panic.

@tsurunoyu tsurunoyu added the bug Something isn't working label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant