Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Certifier should use a more specific query and not get all nouns #1849

Closed
pxp928 opened this issue Apr 18, 2024 · 0 comments · Fixed by #2163
Closed

[feature] Certifier should use a more specific query and not get all nouns #1849

pxp928 opened this issue Apr 18, 2024 · 0 comments · Fixed by #2163
Labels
enhancement New feature or request long-term Things for the future

Comments

@pxp928
Copy link
Collaborator

pxp928 commented Apr 18, 2024

Is your feature request related to a problem? Please describe.
Currently, the certifier query for all packages (for osv) and sources (for scorecard). After the packages are obtained, a neighbors query is called either search for certVuln or scorecard node respectively.

This is very inefficient and results in queries hitting issues specified in the issue #1848.

Describe the solution you'd like

Instead, a specific query should be created (that can be used by the certifiers) for just the packages or sources that need to be either checked or updated (based on a timestamp being set). All the filtering will be done by the database query which will be much more efficient. We may still face the parameter issue faced in issue #1848 so pagination will still be required.

Describe alternatives you've considered
Keep it as it is but as the scale of the DB grows, it will become inefficient.

@pxp928 pxp928 added the enhancement New feature or request label Apr 18, 2024
@pxp928 pxp928 added the long-term Things for the future label Apr 29, 2024
@kodiakhq kodiakhq bot closed this as completed in #2163 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request long-term Things for the future
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant