Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] change clearlydefined certifier to use Metadata.ScannedOn time for hasSourceAt #2154

Open
pxp928 opened this issue Sep 30, 2024 · 0 comments
Open

[bug] change clearlydefined certifier to use Metadata.ScannedOn time for hasSourceAt #2154

pxp928 opened this issue Sep 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@pxp928
Copy link
Collaborator

pxp928 commented Sep 30, 2024 •
edited
Loading

Describe the bug
Currently hasSourceAt uses metadata timestamp which is set when the attestation is created. This needs to be changed to Meta-Updated timestamp which is when Clearly Defined last scanned for this information.

The current timestamp causes the hasSourceAt to node to be re-created because of the KnownSince field changing. More accurately, this should only be re-created when clearly defined has re-scanned on its own service.

Expected behavior
Not recreate hasSourceAt nodes when a the scanned timestamp from clearly defined has not changed during the ceritifer run.

GUAC version
v0.8.8
@pxp928 pxp928 added the bug Something isn't working label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pxp928