Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test run on 'push' confusing #311

Closed
OnnoEbbens opened this issue Jan 3, 2024 · 0 comments · Fixed by #338
Closed

test run on 'push' confusing #311

OnnoEbbens opened this issue Jan 3, 2024 · 0 comments · Fixed by #338

Comments

@OnnoEbbens
Copy link
Collaborator

In the CI file there is a test that is run for a "push" event.

- name: Run notebooks
  if: ${{ github.event_name == 'push' }}
  run: |
    py.test ./tests -m "not notebooks"

The test is confusing because the test is named 'Run notebooks' while the only thing it doesn't run is the notebooks :)

Originally we wanted to test the notebooks only on a 'push' event. Nowadays we use readthedocs to test the notebooks. I think we can remove the tests on "push" completely since we require a PR to change anything to 'dev' or 'main'. Do you agree?

@OnnoEbbens OnnoEbbens linked a pull request Apr 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant