Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark w.r.t the original Silver's code? #22

Open
francescotaioli opened this issue Oct 12, 2022 · 2 comments
Open

Benchmark w.r.t the original Silver's code? #22

francescotaioli opened this issue Oct 12, 2022 · 2 comments
Labels
call contribution appreciated enhancement New feature or request significant

Comments

@francescotaioli
Copy link

francescotaioli commented Oct 12, 2022

Hi,
Is it available a benchmark (speed and memory) w.r.t the original POMCP C++ code? It would interesting also for large POMDPs

@zkytony
Copy link
Collaborator

zkytony commented Oct 12, 2022

Hi @francesco-taioli, no, we don't yet have a benchmark against the original codebase. The C++ codebase will probably be significantly faster and with less memory, because with pomdp-py, even though the POMCP algorithm is implemented in Cython, the POMDP domain (i.e. the models) are implemented in Python, which are slower to sample during planning.

It's indeed good to have a benchmark. Will mark this as todo. I'm not sure when I can get to this, but if you feel like giving it a shot, please go ahead. For practical applications, running a larger amount of simulations might not give you a significant boost in task performance, compared to using a rollout policy with heuristics baked-in.

Also, for what it's worth, the original POMCP source isn't available here any more http://www0.cs.ucl.ac.uk/staff/d.silver/web/Applications_files/pomcp-1.0.tar.gz

@zkytony zkytony added the enhancement New feature or request label Oct 12, 2022
@francescotaioli
Copy link
Author

Thanks @zkytony for the detailed answer.

@zkytony zkytony added the call contribution appreciated label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
call contribution appreciated enhancement New feature or request significant
Projects
None yet
Development

No branches or pull requests

2 participants