Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moodle 4.3 final deprecation of *_get_completion_state() callbacks #550

Open
marcestone opened this issue May 3, 2024 · 0 comments
Open

Moodle 4.3 final deprecation of *_get_completion_state() callbacks #550

marcestone opened this issue May 3, 2024 · 0 comments

Comments

@marcestone
Copy link

Hi!
I found that in https://github.com/h5p/moodle-mod_hvp/blob/stable/lib.php#L453, the hvp_get_completion_state function is still declared in the latest version. According to the Moodle Tracker ticket https://tracker.moodle.org/browse/MDL-71196, the *_get_completion_state() callbacks were deprecated and are being replaced by the activity custom completion classes.
Here it is how the callbacks were replaced in multiple Moodle Core plugins: moodle/moodle@334b6c7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcestone