Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HFP-3850 Disable hub JavaScript only loads when required #530

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

HFP-3850 Disable hub JavaScript only loads when required #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 27 additions & 24 deletions settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,32 +126,35 @@
$hubinfo
));

// Load js for disable hub confirmation dialog functionality.
$PAGE->requires->js('/mod/hvp/library/js/jquery.js', true);
$PAGE->requires->js('/mod/hvp/library/js/h5p-event-dispatcher.js', true);
$PAGE->requires->js('/mod/hvp/library/js/h5p-confirmation-dialog.js', true);
$PAGE->requires->js('/mod/hvp/library/js/settings/h5p-disable-hub.js', true);

// Skip applying css when page has already loaded, since Moodle does not.
// allow us to require the css at this point.
if ($PAGE->state !== 2) {
$PAGE->requires->css('/mod/hvp/library/styles/h5p-confirmation-dialog.css');
$PAGE->requires->css('/mod/hvp/library/styles/h5p.css');
$PAGE->requires->css('/mod/hvp/library/styles/h5p-core-button.css');
}

// Find missing requirements.
$errors = $core->checkSetupErrorMessage()->errors;

$PAGE->requires->data_for_js('H5PDisableHubData', array(
'selector' => '#id_s_mod_hvp_hub_is_enabled',
'overlaySelector' => '#adminsettings',
'header' => get_string('confirmdialogheader', 'hvp'),
'confirmLabel' => get_string('confirmlabel', 'hvp'),
'cancelLabel' => get_string('cancellabel', 'hvp'),
'confirmationDialogMsg' => get_string('disablehubconfirmationmsg', 'hvp'),
'errors' => $errors
));
if (count($errors) > 0) {
// Load js for disable hub confirmation dialog functionality.
$PAGE->requires->js('/mod/hvp/library/js/jquery.js', true);
$PAGE->requires->js('/mod/hvp/library/js/h5p-event-dispatcher.js', true);
$PAGE->requires->js('/mod/hvp/library/js/h5p-confirmation-dialog.js', true);
$PAGE->requires->js('/mod/hvp/library/js/settings/h5p-disable-hub.js', true);

// Skip applying css when page has already loaded, since Moodle does not.
// allow us to require the css at this point.
if ($PAGE->state !== 2) {
$PAGE->requires->css('/mod/hvp/library/styles/h5p-confirmation-dialog.css');
$PAGE->requires->css('/mod/hvp/library/styles/h5p.css');
$PAGE->requires->css('/mod/hvp/library/styles/h5p-core-button.css');
}

// Find missing requirements.

$PAGE->requires->data_for_js('H5PDisableHubData', array(
'selector' => '#id_s_mod_hvp_hub_is_enabled',
'overlaySelector' => '#adminsettings',
'header' => get_string('confirmdialogheader', 'hvp'),
'confirmLabel' => get_string('confirmlabel', 'hvp'),
'cancelLabel' => get_string('cancellabel', 'hvp'),
'confirmationDialogMsg' => get_string('disablehubconfirmationmsg', 'hvp'),
'errors' => $errors
));
}
}

// Prevent Moodle from adding settings block in standard location.
Expand Down