Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Tools data needs spaces #5309

Closed
1 of 5 tasks
JessicaLucindaCheng opened this issue Aug 25, 2023 · 5 comments
Closed
1 of 5 tasks

ER: Tools data needs spaces #5309

JessicaLucindaCheng opened this issue Aug 25, 2023 · 5 comments
Assignees
Labels
Bug Something isn't working Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Aug 25, 2023

Emergent Requirement - Problem

The Tools data is currently displaying without a space after each comma for all the projects that have a Tools field.

Example of problem:
No spaces tools

Issue you discovered this emergent requirement in

Date discovered

August 25, 2023

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@JessicaLucindaCheng

What happens if this is not addressed

It makes the website look less professional.

Resources

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

@JessicaLucindaCheng JessicaLucindaCheng added Bug Something isn't working role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours Issue Making: Level 2 Make issue(s) from an ER or Epic Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level labels Aug 25, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title ER: [replace with info ] ER: Tools data needs spaces Aug 25, 2023
@t-will-gillis
Copy link
Member

Hi @JessicaLucindaCheng - I traced this bug back; it was introduced by unneeded (and unnoted) changes made to current-projects.js by PR #4942 fixes #4136.

I will look at either reverting the relevant code or otherwise fixing it...

@Josiah-O Josiah-O added this to the 03.02 Onboarding flow milestone Aug 26, 2023
@JessicaLucindaCheng
Copy link
Member Author

@t-will-gillis Great! Thanks for looking into it! Did you want to assign yourself to this ER since you are working on it?

@t-will-gillis t-will-gillis self-assigned this Aug 27, 2023
@github-actions
Copy link

Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@t-will-gillis
Copy link
Member

t-will-gillis commented Aug 27, 2023

@JessicaLucindaCheng thanks, will do!

eta: 8/27/23

@t-will-gillis
Copy link
Member

Issue #5321 addresses this issue.

@kimberlytanyh kimberlytanyh added the ER Emergent Request label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

No branches or pull requests

4 participants