Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epic: Refactor img tags in CONTRIBUTING.md to end without a slash #6453

Open
19 tasks done
Tracked by #4362
roslynwythe opened this issue Mar 11, 2024 · 6 comments
Open
19 tasks done
Tracked by #4362

epic: Refactor img tags in CONTRIBUTING.md to end without a slash #6453

roslynwythe opened this issue Mar 11, 2024 · 6 comments
Labels
Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Draft Issue is still in the process of being created epic Feature: Onboarding/Contributing.md good first issue Good for newcomers Issue Making: Level 1 Make issues from a template and a spreadsheet ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Milestone
x. Technical debt

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Mar 11, 2024 •
edited by ExperimentsInHonesty
Loading

Issues for removing closing slash from CONTRIBUTING.md:

Overview

We need to prepare the remaining issues that will remove the closing slash from img tags within CONTRIBUTING.md.

Action Items

  • Find rows in HfLA-Website: img Tag Audit spreadsheet1 where the "Path to file" column is CONTRIBUTING.md and for which the "Link to good first issue" column is blank. These are the rows which require new issues.
  • For each row matching the above criteria, create an issue using the template text in Epic: Create Issues for removing closing slash from img tags #5040 (comment)
    • Give each issue a unique title that describes the location of the issue
    • Replace [Section number] with the section number
    • Replace [INSERT LINE OF CURRENT CODE HERE] with the matching column of the spreadsheet
    • Replace [INSERT DESIRED LINE OF CODE HERE] with the matching column of the spreadsheet
  • List each issue above under "Issues for removing closing slash"
  • After all issues have been created, move this issue into the "Ice Box" and add a Dependency label

Resources/Instructions

Footnotes

  1. HfLA-Website: img Tag Audit spreadsheet's img with Ending Slash tab ↩
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing Issue Making: Level 1 Make issues from a template and a spreadsheet Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level role missing Complexity: Missing labels Mar 11, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
This was referenced Mar 11, 2024
Open
Closed
Closed
@roslynwythe roslynwythe added the Draft Issue is still in the process of being created label Mar 11, 2024
@ExperimentsInHonesty ExperimentsInHonesty added Feature: Onboarding/Contributing.md Dependency An issue is blocking the completion or starting of another issue and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Mar 15, 2024
@ExperimentsInHonesty

This comment was marked as resolved.

Sign in to view
@ExperimentsInHonesty ExperimentsInHonesty added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: missing epic and removed size: missing role missing labels Mar 31, 2024
@ExperimentsInHonesty ExperimentsInHonesty added size: 0.25pt Can be done in 0.5 to 1.5 hours and removed Dependency An issue is blocking the completion or starting of another issue size: missing labels Apr 10, 2024
Open
2 tasks
@roslynwythe
Copy link
Member Author

@roslynwythe can we move this issue to the icebox? Is there anything else it needs for the draft to be complete? Nevermind.

I just realized that those are the issues that have been made, not a dependency. So can we remove the dependency and the draft label and move this into the Epics and ER that are ready to make issues?

OK I will do that, but first I want to check that this is a complete list of issues. I just glanced at the spreadsheet and it looks like there might be more instances of img tags that need to be fixed in CONTRIBUTING, than I listed above, so I need to go through the list again to check.

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
This was referenced Jul 7, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@roslynwythe roslynwythe moved this from New Issue Approval to Ice box in P: HfLA Website: Project Board Sep 2, 2024
@roslynwythe roslynwythe added Dependency An issue is blocking the completion or starting of another issue and removed Draft Issue is still in the process of being created labels Sep 2, 2024
@roslynwythe roslynwythe removed their assignment Sep 2, 2024
@daras-cu daras-cu closed this as completed Oct 1, 2024
@daras-cu daras-cu removed the Dependency An issue is blocking the completion or starting of another issue label Oct 1, 2024
@ExperimentsInHonesty
Copy link
Member

I see the following ending slashes in the contributing file. Unless they are new it seems like they might have been missed

website/CONTRIBUTING.md

Line 845 in 769544a

- If your images are too big, use the <img src="" width="" length="" /> syntax instead of ![image](link) to format the images

website/CONTRIBUTING.md

Line 924 in 769544a

- If your images are too big, use the <img src="" width="" length="" /> syntax instead of ![image](link) to format the images

@github-project-automation github-project-automation bot moved this from QA to New Issue Approval in P: HfLA Website: Project Board Nov 12, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the Draft Issue is still in the process of being created label Nov 13, 2024
@ExperimentsInHonesty
Copy link
Member

I found more items, see comment above. Issues need to be made for this epic before it close.

@ExperimentsInHonesty ExperimentsInHonesty added the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Draft Issue is still in the process of being created epic Feature: Onboarding/Contributing.md good first issue Good for newcomers Issue Making: Level 1 Make issues from a template and a spreadsheet ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
P: HfLA Website: Project Board
Status: New Issue Approval
Milestone
x. Technical debt
Development

No branches or pull requests
3 participants
@roslynwythe @ExperimentsInHonesty @daras-cu