Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text alignment on the Join Us page and the About page headers #7304

Closed
5 tasks done
ramitaarora opened this issue Aug 16, 2024 · 6 comments · Fixed by #7467
Closed
5 tasks done

Fix text alignment on the Join Us page and the About page headers #7304

ramitaarora opened this issue Aug 16, 2024 · 6 comments · Fixed by #7467
Assignees
Labels
Complexity: Medium P-Feature: Join Page https://www.hackforla.org/join role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@ramitaarora
Copy link
Member

ramitaarora commented Aug 16, 2024

Overview

We need to fix the alignment of the second paragraph in both the Join Us page and the About page headers. They are currently aligned in the center, but should be left-aligned. The text alignment for the header paragraphs will not be uniform on the Join Us and About Us pages (and possibly other pages if the paragraph text is changed).

Click here to see the desired paragraphs' text alignment at 1440px screen width

Join Us page

About Us page

Action Items

  • Open the file _sass/elements/_containers.scss in IDE
  • Fix the paragraphs' text alignment on the Join Us and About Us page. This requires fixing the SCSS.
  • Using docker, verify the elements on the About page and Join Us page. For all the pages on the site that have paragraph(s) in the header section of the page, the paragraph(s) on all the headers should be left justified. So, check this for each page.
  • Check the website looks good in mobile, tablet, and desktop views and nothing is broken by the changes you made.
  • Create a PR when finished.

Resources/Instructions

Mentioned in #5973.

@ramitaarora ramitaarora added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Join Page https://www.hackforla.org/join size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 16, 2024
@ramitaarora ramitaarora added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Aug 21, 2024
@pluto-bell pluto-bell self-assigned this Aug 30, 2024
@HackforLABot

This comment was marked as outdated.

@roslynwythe roslynwythe added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers labels Sep 2, 2024
@vorleakyek vorleakyek self-assigned this Sep 15, 2024
@HackforLABot
Copy link
Contributor

Hi @vorleakyek, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@vorleakyek
Copy link
Member

i. Availability: Mon, Tue-Friday evening
ii. ETA: 1-2 hrs

@vorleakyek
Copy link
Member

vorleakyek commented Sep 16, 2024

@ramitaarora, when the screen size is around 950px, we just want to align the second paragraph with the first paragraph, correct? So, the blue line padding there should not be changed? Please confirm this so that I can try to look for a better solution. Thanks!
image

@ramitaarora
Copy link
Member Author

@vorleakyek I believe you are correct!
@JessicaLucindaCheng, I just want to check if that is correct and if there is a figma file we can reference?

@vorleakyek
Copy link
Member

Provide Update:

  1. Progress: I made the changes based on the comment from the reviewer.
  2. Blockers: Just waiting for the PR review.
  3. Availability: M-F evening
  4. ETA: based on the comment from the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Join Page https://www.hackforla.org/join role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Development

Successfully merging a pull request may close this issue.

6 participants