Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paragraphs alignment in the About Us and Join Us pages #7467

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

vorleakyek
Copy link
Member

@vorleakyek vorleakyek commented Sep 17, 2024

Fixes #7304

What changes did you make?

  • Add a width: 100% property under .sub-p in the _sass/elements/_containers.scss file.
  • Note: This change is for all screen sizes (mobile, tablet, and desktop).

Why did you make the changes (we will use this info to test)?

  • Ensure the width of the second paragraph will be 100% so that it aligns properly with the paragraph above it.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals Before and After the changes for the Join Us page
Visuals Before and After the changes for the About Us page

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b vorleakyek-fix-text-alignment-7304 gh-pages
git pull https://github.com/vorleakyek/website.git fix-text-alignment-7304

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Medium P-Feature: Join Page https://www.hackforla.org/join size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 17, 2024
@vorleakyek vorleakyek changed the title Fix text alignment 7304 Fix paragraphs alignment in the About Us and Join Us pages - 7304 Sep 18, 2024
@vorleakyek vorleakyek changed the title Fix paragraphs alignment in the About Us and Join Us pages - 7304 Fix paragraphs alignment in the About Us and Join Us pages Sep 18, 2024
Copy link
Member

@Thinking-Panda Thinking-Panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vorleakyek Making similar changes to the .sub-p class in _containers.scss and adding styles for @media #{$bp-below-tablet} viewport will achieve the desired results. Let me know in case you have any questions.

@codyyjxn codyyjxn self-requested a review September 19, 2024 04:30
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vorleakyek Thank you for taking on this issue.
Great branch name.
Title is clear and description as well.
Screenshots before and after are great!

@vorleakyek
Copy link
Member Author

vorleakyek commented Sep 19, 2024

Thanks for the suggestion @Thinking-Panda! I modified the .sub-p class in _containers.scss file. The display seems to work properly in the local environment.

Thanks @codyyjxn for starting to take a look.

@vorleakyek
Copy link
Member Author

Hi @Thinking-Panda and @codyyjxn, please take another look at my PR and let me know if there is anything that I should change.
Note: I've applied the change for all screen sizes (mobile, tablet, and desktop).
Thanks!

@t-will-gillis
Copy link
Member

Hello @Thinking-Panda and @codyyjxn Please let us know when you will be able to re-review the changes made by @vorleakyek. Thank you!

@Thinking-Panda
Copy link
Member

Availability: M-Th 10-3
ETA 9/24

Copy link
Member

@Thinking-Panda Thinking-Panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vorleakyek Merge branches are set up correct. Changes are as mentioned in the issue producing desired result in all pages and in all viewports. Well done. Approved!

_sass/elements/_containers.scss Show resolved Hide resolved
@jphamtv jphamtv merged commit 9017fc2 into hackforla:gh-pages Sep 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Join Page https://www.hackforla.org/join role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Fix text alignment on the Join Us page and the About page headers
5 participants