Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'All tests passed' message is incorrect #3

Open
Krushr opened this issue May 6, 2013 · 2 comments
Open

'All tests passed' message is incorrect #3

Krushr opened this issue May 6, 2013 · 2 comments

Comments

@Krushr
Copy link

Krushr commented May 6, 2013

There are cases on Semaphore where branches have failed but mightn't have failing tests on them, or other tests which aren't run through rspec failed, or someone stopped the build.

Perhaps a better message would be 'Unable to find any failing RSpec tests'?

@hackling
Copy link
Owner

I have also noticed that if a branch times out on semaphore, that is also returns the 'All tests passed' message as it doesn't find the summary output.

Some work needs to be done to the regex, so that it detects that the 'end of test suite' output is actually present, and that other types of tests are actually detected as well.

@hackling
Copy link
Owner

Also now that Semaphore emits more with regards to branch status (the addition of stopped), we should provide more descriptive feedback to the user, and potentially scan the log of the previous run that actually completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants