Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[concourse]: cleanup repositry directory on failure #110

Open
kallisti5 opened this issue Jan 8, 2024 · 1 comment
Open

[concourse]: cleanup repositry directory on failure #110

kallisti5 opened this issue Jan 8, 2024 · 1 comment

Comments

@kallisti5
Copy link
Contributor

kallisti5 commented Jan 8, 2024

In the event of an upload failure, the concourse pipelines can leave a "broken" repository for an hrev.

We should likely investigate an on_failure step which cleans up the hrev folder in s3 if the upload fails.
However, in the event that s3 is 100% unavailable, this may not work.

failure

The better solution is hpkgbouncer needs to validate the "completeness" of the hrev repository directory before sending users there. This would likely be accomplished by:

  • Examining each repo file
  • Validating that all packages exist for the given repo file, and the sha256 checksums are valid
  • Adding to RepositoryCache

hpkg bouncer needs a native rust crate that can read hpkr files however to accomplish this.

@kallisti5 kallisti5 changed the title [concourse: [concourse]: cleanup on failure Jan 8, 2024
@kallisti5 kallisti5 changed the title [concourse]: cleanup on failure [concourse]: cleanup repositry directory on failure Jan 8, 2024
@kallisti5
Copy link
Contributor Author

A note for future viewers: The workaround is to kick off a new concourse job to re-build and re-upload the failed hrev repo. (or manually delete the folder from s3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant