Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable marks #14

Open
hadrysmateusz opened this issue Aug 13, 2020 · 2 comments
Open

Customizable marks #14

hadrysmateusz opened this issue Aug 13, 2020 · 2 comments

Comments

@hadrysmateusz
Copy link
Contributor

It would be great if the mark types could be customized like nodes.

For example, to change strikeThrough to strikethrough or strike-through.
@hanford
Copy link
Owner

hanford commented Aug 14, 2020

I agree, this seems like something we should add support for.

Probably can use the same API as default node types: https://github.com/hanford/remark-slate/blob/master/src/deserialize.ts#L39

@hadrysmateusz
Copy link
Contributor Author

Yeah, I was thinking the same. When I have some free time I might make a PR, unless you want to do it yourself.

dylans added a commit to dylans/remark-slate that referenced this issue Dec 14, 2020
@dylans
refs hanford#14, customizable marks
86c61ee
hanford pushed a commit that referenced this issue Dec 26, 2020
@dylans
refs #14, customizable marks (#23)
cd23a65 
Co-authored-by: Dylan Schiemann <dylan@livingspec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hanford @hadrysmateusz