Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Intrinsic Gas Cost in eth_sendRawTransaction precheck #1631

Closed
georgi-l95 opened this issue Aug 11, 2023 · 1 comment · Fixed by #1637 or #1774
Closed

Wrong Intrinsic Gas Cost in eth_sendRawTransaction precheck #1631

georgi-l95 opened this issue Aug 11, 2023 · 1 comment · Fixed by #1637 or #1774
Assignees
@georgi-l95
Labels
bug Something isn't working
Milestone
0.33.0

Comments

@georgi-l95
Copy link
Collaborator

Description

Wrong intrinsic gas is calculated by eth_sendRawTransaction precheck in all cases. For example deploying this greeter contract takes around 79-80k gas, but relay calculates that it needs at least 160k. This results in error throw in the relay even before the transaction reaches consensus node.

This bug didn't surface until now, because we've used hardcoded values for estimateGas, now that we have precise calculation of estimate gas from the mirror-node it appears that relay calculations were wrong.

Steps to reproduce

  1. Deploy contract using image from this PR, which now calculates correct estimateGas

Additional context

No response

Hedera network

other

Version

main

Operating system

None
@georgi-l95 georgi-l95 added the bug Something isn't working label Aug 11, 2023
@georgi-l95 georgi-l95 self-assigned this Aug 11, 2023
@georgi-l95 georgi-l95 moved this to In Progress in Smart Contract Sprint Board Aug 11, 2023
@georgi-l95 georgi-l95 linked a pull request Aug 12, 2023 that will close this issue
Fix Wrong Intrinsic gas cost in eth_sendRawTransaction precheck calculation #1637
Merged
2 tasks
@georgi-l95 georgi-l95 mentioned this issue Aug 12, 2023
Merged
2 tasks
@kabaluyot
Copy link

Got similar issues because of eth_sendRawTransaction too checking from logs

@kabaluyot kabaluyot mentioned this issue Aug 22, 2023
Closed
@Nana-EC Nana-EC added this to the 0.32.0 milestone Sep 5, 2023
@AlfredoG87 AlfredoG87 modified the milestones: 0.32.0, 0.33.0 Sep 18, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Smart Contract Sprint Board Sep 25, 2023
@Nana-EC Nana-EC mentioned this issue Oct 5, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgi-l95 georgi-l95

Labels
bug Something isn't working
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.33.0
4 participants
@georgi-l95 @kabaluyot @Nana-EC @AlfredoG87