Merge branch 'dev' into create-token-api

Signed-off-by: Kiran Pachhai <kiran@pachhai.com>

.github/workflows/run-eslint.yml

@@ -0,0 +1,27 @@
+name: Lint Snap Code
+
+on: [push, pull_request]
+
+jobs:
+  eslint:
+    name: Run ESLint For Snap
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+        name: Check out source code
+
+      - uses: actions/setup-node@v2
+        name: Set up Node.js
+        with:
+          node-version: '18'
+          cache: 'yarn'
+          cache-dependency-path: packages/hedera-wallet-snap/packages/snap
+
+      - name: Install Dependencies in Subdirectory
+        run: yarn install
+        working-directory: ./packages/hedera-wallet-snap/packages/snap
+
+      - name: Run ESLint in Subdirectory
+        run: yarn lint
+        working-directory: ./packages/hedera-wallet-snap/packages/snap

.github/workflows/run-jest-unit-snap.yml

@@ -0,0 +1,27 @@
+name: Run Hedera Pulse Snap Unit Tests
+
+on: [push]
+
+jobs:
+  eslint:
+    name: Run Hedera Pulse Snap Unit Tests
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+        name: Check out source code
+
+      - uses: actions/setup-node@v2
+        name: Set up Node.js
+        with:
+          node-version: '18'
+          cache: 'yarn'
+          cache-dependency-path: packages/hedera-wallet-snap/packages/snap
+
+      - name: Install Dependencies in Subdirectory
+        run: yarn install
+        working-directory: ./packages/hedera-wallet-snap/packages/snap
+
+      - name: Run Snap Unit Tests
+        run: yarn test
+        working-directory: ./packages/hedera-wallet-snap/packages/snap

packages/hedera-wallet-snap/package.json

@@ -39,7 +39,7 @@
     "eslint-plugin-jest": "^27.4.0",
     "eslint-plugin-jsdoc": "^46.8.1",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-prettier": "5.0.0",
     "prettier": "^3.0.3",
     "prettier-plugin-packagejson": "^2.4.5",
     "typescript": "^5.2.2"

packages/hedera-wallet-snap/packages/snap/.eslintrc.js

@@ -15,5 +15,5 @@ module.exports = {
     project: './tsconfig.eslint.json',
     sourceType: 'module',
   },
-  ignorePatterns: ['!.eslintrc.js', 'dist/', './postBuild.js'],
+  ignorePatterns: ['!.eslintrc.js', 'dist/', './postBuild.js','jest.config.js'],
 };

packages/hedera-wallet-snap/packages/snap/jest.config.js

@@ -16,5 +16,5 @@ module.exports = {
   testEnvironment: 'node',
   testRegex: '.*\\.spec\\.ts$',
   transformIgnorePatterns: [],
-  testTimeout: 120000
+  testTimeout: 120000,
 };

packages/hedera-wallet-snap/packages/snap/package.json

@@ -44,7 +44,7 @@
     "lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' --ignore-path .gitignore",
     "serve": "mm-snap serve",
     "start": "mm-snap --version && concurrently \"yarn build && yarn serve\" \"yarn watch\"",
-    "test": "jest --forceExit",
+    "test": "jest --forceExit --verbose",
     "test:ci": "yarn test --silent",
     "watch": "chokidar 'src/' -c 'yarn build'"
   },
@@ -58,6 +58,7 @@
     "@metamask/snaps-ui": "^1.0.1",
     "bignumber.js": "^9.1.1",
     "ethers": "^6.3.0",
+    "jest-mock": "^29.7.0",
     "lodash": "^4.17.21",
     "normalize-url": "^8.0.0"
   },

packages/hedera-wallet-snap/packages/snap/src/utils/__tests__/CryptoUtils.spec.ts

@@ -12,7 +12,8 @@ describe('CryptoUtils', () => {
     });
 
     it('should validate an Ethereum public key', () => {
-      const publicKey = '0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa';
+      const publicKey =
+        '0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa';
       mockedIsHexString.mockReturnValue(true);
 
       const result = CryptoUtils.isValidEthereumPublicKey(publicKey);
@@ -62,7 +63,9 @@ describe('CryptoUtils', () => {
 
     it('should throw an error for invalid hex strings', () => {
       const hexString = 'abc';
-      expect(() => CryptoUtils.hexToUInt8Array(hexString)).toThrow('Invalid hex string');
+      expect(() => CryptoUtils.hexToUInt8Array(hexString)).toThrow(
+        'Invalid hex string',
+      );
     });
   });
 });

packages/hedera-wallet-snap/packages/snap/src/utils/__tests__/FetchUtils.spec.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-globals */
 import { FetchUtils, FetchResponse } from '../FetchUtils';
 
 global.fetch = jest.fn();

packages/hedera-wallet-snap/packages/snap/src/utils/__tests__/StateUtils.spec.ts

@@ -1,9 +1,10 @@
 import { StateUtils } from '../StateUtils';
 import { WalletAccountState, WalletSnapState } from '../../types/state';
+
 describe('StateUtils', () => {
   describe('getEmptyAccountState', () => {
     it('returns a deep clone of emptyAccountState', () => {
-      const state : WalletAccountState = StateUtils.getEmptyAccountState();
+      const state: WalletAccountState = StateUtils.getEmptyAccountState();
       expect(state).toEqual({
         keyStore: {
           curve: 'ECDSA_SECP256K1',
@@ -17,14 +18,14 @@ describe('StateUtils', () => {
 
       // Verify deep clone by mutation
       state.keyStore.curve = 'ED25519';
-      const newState : WalletAccountState = StateUtils.getEmptyAccountState();
+      const newState: WalletAccountState = StateUtils.getEmptyAccountState();
       expect(newState.keyStore.curve).toBe('ECDSA_SECP256K1');
     });
   });
 
   describe('getInitialSnapState', () => {
     it('returns a deep clone of initialSnapState', () => {
-      const snapState:WalletSnapState = StateUtils.getInitialSnapState();
+      const snapState: WalletSnapState = StateUtils.getInitialSnapState();
       expect(snapState).toEqual({
         currentAccount: {},
         accountState: {},
@@ -41,7 +42,7 @@ describe('StateUtils', () => {
 
       // Verify deep clone by mutation
       snapState.snapConfig.dApp.disablePopups = true;
-      const newSnapState:WalletSnapState = StateUtils.getInitialSnapState();
+      const newSnapState: WalletSnapState = StateUtils.getInitialSnapState();
       expect(newSnapState.snapConfig.dApp.disablePopups).toBe(false);
     });
   });

packages/hedera-wallet-snap/packages/snap/src/utils/__tests__/TuumUtils.spec.ts

@@ -12,7 +12,10 @@ describe('HederaWalletUtils', () => {
         maxCost: 115.5, // (100 + 10) * 1.05
       };
 
-      const result = TuumUtils.calculateHederaQueryFees(queryCost, serviceFeePercentage);
+      const result = TuumUtils.calculateHederaQueryFees(
+        queryCost,
+        serviceFeePercentage,
+      );
 
       expect(result.serviceFeeToPay).toBeCloseTo(expected.serviceFeeToPay);
       expect(result.maxCost).toBeCloseTo(expected.maxCost);
@@ -21,8 +24,8 @@ describe('HederaWalletUtils', () => {
 
   describe('deductServiceFee', () => {
     it('should call transferCrypto with correct parameters', async () => {
-      //note that jest is having issues with classes with nested includes
-      //since we're doing the instance refactor next going to leave this as-is
+      // note that jest is having issues with classes with nested includes
+      // since we're doing the instance refactor next going to leave this as-is
     });
   });
 });

packages/hedera-wallet-snap/packages/snap/src/utils/__tests__/Utils.spec.ts

@@ -24,7 +24,7 @@ describe('HederaWalletSnap', () => {
 
     test('should convert a string representation of a timestamp to a UTC string', () => {
       const timestamp = '1672444800'; // Equivalent to 2023-01-01T00:00:00Z
-      const expected = new Date(parseInt(timestamp) * 1000).toUTCString();
+      const expected = new Date(parseInt(timestamp, 10) * 1000).toUTCString();
       expect(Utils.timestampToString(timestamp)).toBe(expected);
     });
 

packages/hedera-wallet-snap/packages/snap/tsconfig.json

@@ -10,5 +10,6 @@
     "removeComments": true
   },
   "files": ["./json-typings.d.ts"],
+  "exclude": ["./jest.config.js"],
   "include": ["src/**/*"]
 }