Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP-584: Add tests for estimateGas with precompiles #6241

Merged
merged 37 commits into from
Sep 1, 2023
Merged

HIP-584: Add tests for estimateGas with precompiles #6241

merged 37 commits into from
Sep 1, 2023

Conversation

yiliev0
Copy link
Contributor

@yiliev0 yiliev0 commented Jun 20, 2023 •
edited by steven-sheehy
Loading

Description:

This PR contains tests related to eth_estimateGas with precompiles. It covers test cases related to:

  • associateToken, dissociateToken, associateTokens, dissociateTokens
  • approve, approveNFT, ERC approve, setAprovalForAll, getApproved, ERC getApproved, isApprovedForAll, ERC isApprovedForAll
  • allowance, ERC allowance
  • mintToken, burnToken
  • transferFrom, transferFromNFT, transferToken, transferNFT, transferTokens, transferNFTs, cryptoTransfer, ERC Transfer, ERC transferFrom
  • wipeTokenAccount, wipeTokenAccountNFT
  • grantTokenKYC, revokeTokenKYC
  • freezeToken, unfreezeToken, pauseToken, unpauseToken
  • createFungibleToken, createNonFungibleToken, createFungibleTokenWithCustomFees, createNonFungibleTokenWithCustomFees
  • deleteToken
  • updateTokenExpiryInfo, updateTokenInfo, updateTokenKeys
  • ERC read functions -> name, symbol, decimals, totalSupply, balanceOf, ownerOf, tokenURI, getTokenInfo, isKYC, isFrozen, getTokenType
  • redirectForToken

Related issue(s):

Fixes #6109

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@yiliev0 yiliev0 marked this pull request as draft June 20, 2023 13:39
@codecov
Copy link

codecov bot commented Jun 20, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.21% 🎉

Comparison is base (8f04c80) 92.50% compared to head (df0880e) 92.71%.
Report is 65 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6241      +/-   ##
============================================
+ Coverage     92.50%   92.71%   +0.21%     
  Complexity     6526     6526              
============================================
  Files           794      838      +44     
  Lines         25116    27512    +2396     
  Branches       3144     3157      +13     
============================================
+ Hits          23233    25508    +2275     
- Misses         1208     1290      +82     
- Partials        675      714      +39
Files Changed Coverage Δ
...tore/contracts/precompile/SyntheticTxnFactory.java 96.24% <ø> (+0.28%) ⬆️

... and 157 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IvanKavaldzhiev IvanKavaldzhiev added test Test infrastructure, automated tests required, etc web3 Area: Web3 API limechain Work planned for the LimeChain team labels Jun 23, 2023
@yiliev0 yiliev0 force-pushed the 6109-tests-for-eth-estimateGas-with-precompiles branch from 5a48263 to 196805f Compare July 7, 2023 08:01
@yiliev0
Add tests for estimateGas with precompiles related to associate, diss…
fa09343 
…ociate, approve, transfer

Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Adding tests related to mint, burn, create, wipe, grant/revoke kyc
7c390a9 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Addding more tests related to KYC, freeze, unfreeze
957d614 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Adding more functions to the contract
e9bca5d 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Remove unncessery commented code and add valid compiled contract json
89212b9 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Adding tests for freeze/unfreeze & verifyTX wait function for the rec…
f249160 
…ord file arrival in mirror node

Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Applying headlong encoding for request data, adding tests for wipe pr…
2fce08c 
…ecompile.

Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Add tests related to delete, pause/unpause, freeze/unfreeze, ERC appr…
7a45de9 
…ove/transferFrom/transfer

Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Changes to approve tests, enabling all working precompile tests, addi…
d9852be 
…ng function for associate/approveNftAll to work with contract id

Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Resolve merge conflicts
de4c0d3 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0 yiliev0 force-pushed the 6109-tests-for-eth-estimateGas-with-precompiles branch from 0119e0b to de4c0d3 Compare July 27, 2023 07:01
yiliev0 and others added 11 commits July 31, 2023 09:38
@yiliev0
Adding new tests related to update tokenInfo, keys and expiry
87df76d 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Adding function for grantKYC for contract, erc transfer test changes
5d17356 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Changes to transfer tests, adding new tests
31ca8f5 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Adding new tests related to erc name, symbol, decimals, totalSupply, …
b4e7494 
…balanceOf, ownerOf, tokenURI

Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Adding new tests - read precompiles
a00574d 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Changes to redirect test, creating parent class AbstractEstimateFeature
601716b 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Adding new tests for redirectForToken precompile
6053386 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@mustafauzunn
Merge branch 'main' of github.com:hashgraph/hedera-mirror-node into 6…
1a68104 
…109-tests-for-eth-estimateGas-with-precompiles

# Conflicts:
#	hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/client/TokenClient.java
@mustafauzunn
style: spotless
0543365 
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@yiliev0
Changes to Create precompile tests->adding value to the request and e…
619f170 
…diting the actualGas value

Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Changes to EstimatePrecompileContract -> adding return statements
af23879 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Adding acceptance annotation to the feature file
0140032 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Replace string-based enum lookup with static imports
11dc38e 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Fix missing verb in feature description
ef27571 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Removing duplicate contract creation
469261f 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Refine function retrieval using ContractMethods enums
7b17ba8 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Refactor: Moved duplicated contract methods to AbstractFeature
2ca9cfa 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Removing unused imports
793360e 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Refactor: Centralise ObjectMapper in MapperConfiguration; Update Abst…
b3381ca 
…ractFeature's createContract for InputStream

Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0
Add wait mechanism for HAPI transactions prior to web3 calls
101810f 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
steven-sheehy
steven-sheehy requested changes Aug 31, 2023
View reviewed changes
...ror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/config/MapperConfiguration.java Show resolved Hide resolved
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/AbstractFeature.java Outdated Show resolved Hide resolved
hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/CallFeature.java Outdated Show resolved Hide resolved
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/ContractFeature.java Outdated Show resolved Hide resolved
hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/CallFeature.java Outdated Show resolved Hide resolved
...irror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/ERCContractFeature.java Outdated Show resolved Hide resolved
...est/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/EstimatePrecompileFeature.java Outdated Show resolved Hide resolved
...est/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/PrecompileContractFeature.java Outdated Show resolved Hide resolved
@yiliev0
Changes based on PR comments & spotless apply
df0880e 
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

steven-sheehy
steven-sheehy approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing the extra cleanup to reduce duplication!

@steven-sheehy steven-sheehy merged commit d642cfb into main Sep 1, 2023
27 checks passed
@steven-sheehy steven-sheehy deleted the 6109-tests-for-eth-estimateGas-with-precompiles branch September 1, 2023 16:09
@yiliev0 yiliev0 mentioned this pull request Sep 4, 2023
Closed
This was referenced Oct 30, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@IvanKavaldzhiev IvanKavaldzhiev Awaiting requested review from IvanKavaldzhiev

@0xivanov 0xivanov Awaiting requested review from 0xivanov

@agadzhalov agadzhalov Awaiting requested review from agadzhalov

@attest08 attest08 Awaiting requested review from attest08

Assignees

@yiliev0 yiliev0

Labels
limechain Work planned for the LimeChain team test Test infrastructure, automated tests required, etc web3 Area: Web3 API
Projects
None yet
Milestone
0.88.0
Development

Successfully merging this pull request may close these issues.

HIP-584: Add tests for eth_estimateGas with precompiles
4 participants
@yiliev0 @IvanKavaldzhiev @steven-sheehy @mustafauzunn