Creating a working example for contract calls #6630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6630 +/- ##
============================================
- Coverage 92.70% 92.69% -0.01%
+ Complexity 6392 6391 -1
============================================
Files 823 823
Lines 27079 27079
Branches 3104 3104
============================================
- Hits 25104 25102 -2
- Misses 1270 1271 +1
- Partials 705 706 +1 ☔ View full report in Codecov by Sentry. |
| @@ -2446,7 +2446,7 @@ components: | |||
| type: integer | |||
| to: | |||
| description: The 20-byte hexadecimal EVM address the transaction is directed to. | |||
| example: "0x00000000000000000000000000000000000003f4" | |||
| example: "0xD9d0c5C0Ff85758BdF05A7636F8036d4D065F5B6" | |||
There was a problem hiding this comment.
nit: prefer lowercase hex like the other examples
There was a problem hiding this comment.
Fixed.
I agree in general lowercase is good for any other value, but for addresses I usually prefer the checksum version.
steven-sheehy
added
the
documentation
Neurone
force-pushed
the
fix-contract-call-example-payload
branch
from
bec76bd
to
f79e17b
Compare
Signed-off-by: Giuseppe Bertone <giuseppe.bertone@swirldslabs.com>
Neurone
force-pushed
the
fix-contract-call-example-payload
branch
from
f79e17b
to
8b4289b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the Swagger UI, the current example payload for the endpoint /api/v1/contracts/call contains some errors:
This PR modifies the example payload, so the user can test the API without customizing the payload.
Related issue(s):
N/A
Notes for reviewer:
N/A
Checklist