Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenApiValidator feature flag #9784

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Add OpenApiValidator feature flag #9784

merged 2 commits into from
Nov 19, 2024

Conversation

edwin-greene
Copy link
Contributor

Description:
Adds a feature flag, defaulted to false, for the REST API OpenAPI Validator request validation.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
@edwin-greene edwin-greene added enhancement Type: New feature rest Area: REST API labels Nov 19, 2024
@edwin-greene edwin-greene self-assigned this Nov 19, 2024
@edwin-greene edwin-greene requested a review from a team as a code owner November 19, 2024 16:17
@edwin-greene edwin-greene added this to the 0.119.0 milestone Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (d84e4c2) to head (523c5a0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9784   +/-   ##
=========================================
  Coverage     92.25%   92.25%           
  Complexity     7769     7769           
=========================================
  Files           950      950           
  Lines         32450    32452    +2     
  Branches       4113     4114    +1     
=========================================
+ Hits          29936    29938    +2     
  Misses         1546     1546           
  Partials        968      968           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Copy link

sonarcloud bot commented Nov 19, 2024

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwin-greene edwin-greene merged commit 0253168 into main Nov 19, 2024
34 checks passed
@edwin-greene edwin-greene deleted the openApiFeatureFlag branch November 19, 2024 17:56
edwin-greene added a commit that referenced this pull request Nov 19, 2024
* Add OpenApiValidator feature flag

---------

Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
(cherry picked from commit 0253168)
edwin-greene added a commit that referenced this pull request Nov 19, 2024
* Add OpenApiValidator feature flag

---------

Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
(cherry picked from commit 0253168)
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
edwin-greene added a commit that referenced this pull request Nov 19, 2024
* Add OpenApiValidator feature flag (#9784)

Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature rest Area: REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants