AccountReadableKVState returns account with AccountNum accountId #9801
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9801 +/- ##
============================================
+ Coverage 88.72% 92.34% +3.62%
- Complexity 1166 7665 +6499
============================================
Files 378 932 +554
Lines 12135 32196 +20061
Branches 1715 4092 +2377
============================================
+ Hits 10767 29733 +18966
- Misses 1224 1500 +276
- Partials 144 963 +819 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
hedera-mirror-web3/src/main/java/com/hedera/services/utils/EntityIdUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
kselveliev
requested review from
bilyana-gospodinova,
IvanKavaldzhiev,
steven-sheehy,
nickeynikolovv and
sdimitrov9
|
steven-sheehy
approved these changes
Nov 22, 2024
steven-sheehy
changed the title
steven-sheehy
deleted the
09800-account-readable-kv-state-improvement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
AccountReadableKVStatemust return the accountId of the account with a typeAccountNumFull issue and reason for solution described in the issue that this pr fixes
This PR modifies:
AccountReadableKVState- use toAccountNumIdmethod for getting the accountIdEntityIdUtils- addtoAccountNumIdmethod that takes and entity parameter and returnAccountIDwithaccountNumtypeRelated issue(s):
Fixes #9800
Notes for reviewer:
Checklist