Add return statement to HederaTokenService.redirectForToken()
#299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <n.atanasow94@gmail.com>
natanasow
requested review from
AlfredoG87,
ebadiere,
georgi-l95,
Ivo-Yankov,
Nana-EC and
a team
as code owners
natanasow
added
enhancement
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Nana-EC
previously approved these changes
Aug 7, 2023
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Nana-EC
approved these changes
Aug 7, 2023
mshakeg
pushed a commit
to mshakeg/hedera-smart-contracts
that referenced
this pull request
Oct 14, 2023
…graph#299) * Add return statement Signed-off-by: nikolay <n.atanasow94@gmail.com> * Return responseCode instead of success flag Signed-off-by: nikolay <n.atanasow94@gmail.com> * Add comments Signed-off-by: nikolay <n.atanasow94@gmail.com> * Update artifacts Signed-off-by: nikolay <n.atanasow94@gmail.com> --------- Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: Mo Shaikjee <shaikjeemohammed@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, there is no return statement in HederaTokenService.redirectForToken(), so we can not call that contract from an external contract and get the result.
Related issue(s):
Fixes #298
Notes for reviewer:
Checklist